Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Fix unused createChannel option #3452

Merged
merged 1 commit into from
Oct 27, 2024
Merged

Conversation

lorisleiva
Copy link
Contributor

@lorisleiva lorisleiva commented Oct 25, 2024

This PR removes the unused DefaultRpcSubscriptionsTransportConfig type from the DefaultRpcSubscriptionsConfig type. The former simply provides a createChannel attribute that is never used within the default subscription helpers because they provide their own createChannel to the underlying default transport.

Copy link

changeset-bot bot commented Oct 25, 2024

⚠️ No Changeset found

Latest commit: d75304a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

lorisleiva commented Oct 27, 2024

Merge activity

  • Oct 27, 6:03 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 27, 6:18 AM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 27, 6:19 AM EDT: A user merged this pull request with Graphite.

@lorisleiva lorisleiva changed the base branch from loris/add-bigint-json-channel-decorator to graphite-base/3452 October 27, 2024 10:14
@lorisleiva lorisleiva changed the base branch from graphite-base/3452 to master October 27, 2024 10:16

Verified

This commit was signed with the committer’s verified signature.
yuzawa-san James Yuzawa
@lorisleiva lorisleiva force-pushed the loris/fix-unused-config-attribute branch from 829dadc to d75304a Compare October 27, 2024 10:17
@lorisleiva lorisleiva merged commit 8f2ccc6 into master Oct 27, 2024
4 of 6 checks passed
@lorisleiva lorisleiva deleted the loris/fix-unused-config-attribute branch October 27, 2024 10:19
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants