Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Move BigInt JSON parse and strigify functions to rpc-spec-types #3443

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

lorisleiva
Copy link
Contributor

@lorisleiva lorisleiva commented Oct 24, 2024

This PR moves the parseJsonWithBigInts and stringifyJsonWithBigints functions from the rpc-transport-http package to the rpc-spec-types package in order to reuse them within RPC Subscriptions packages.

Note that the library now explicitly re-exports a subset of the rpc-spec-types to avoid flooding the namespace with internal type and functions.

Copy link

changeset-bot bot commented Oct 24, 2024

⚠️ No Changeset found

Latest commit: 17bdc37

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

This was referenced Oct 24, 2024
@lorisleiva lorisleiva force-pushed the loris/move-bigint-json-functions branch from c60f924 to 190a861 Compare October 24, 2024 12:37
@lorisleiva lorisleiva force-pushed the loris/run-examples-in-ci branch from 53d7512 to 6f2b161 Compare October 24, 2024 13:15
@lorisleiva lorisleiva force-pushed the loris/move-bigint-json-functions branch from 190a861 to f46a186 Compare October 24, 2024 13:16
@lorisleiva lorisleiva force-pushed the loris/run-examples-in-ci branch from 6f2b161 to fefae65 Compare October 24, 2024 13:18
@lorisleiva lorisleiva force-pushed the loris/move-bigint-json-functions branch from f46a186 to 6a2da75 Compare October 24, 2024 13:18
@lorisleiva lorisleiva changed the base branch from loris/run-examples-in-ci to loris/update-failing-example October 24, 2024 13:18
@lorisleiva lorisleiva force-pushed the loris/move-bigint-json-functions branch from 6a2da75 to e58940e Compare October 24, 2024 13:31
@lorisleiva lorisleiva changed the base branch from loris/update-failing-example to master October 24, 2024 13:32
@lorisleiva lorisleiva force-pushed the loris/move-bigint-json-functions branch 2 times, most recently from 79ebfb7 to 66df5cc Compare October 24, 2024 15:42
Copy link
Contributor

@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added via Giphy

Copy link
Contributor Author

lorisleiva commented Oct 27, 2024

Merge activity

  • Oct 27, 6:03 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 27, 6:04 AM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 27, 6:05 AM EDT: A user merged this pull request with Graphite.

@lorisleiva lorisleiva force-pushed the loris/move-bigint-json-functions branch from b831f90 to 17bdc37 Compare October 27, 2024 10:04
@lorisleiva lorisleiva merged commit 9a9cceb into master Oct 27, 2024
6 checks passed
@lorisleiva lorisleiva deleted the loris/move-bigint-json-functions branch October 27, 2024 10:05
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants