This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 925
Move BigInt JSON parse and strigify functions to rpc-spec-types
#3443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was referenced Oct 24, 2024
lorisleiva
force-pushed
the
loris/move-bigint-json-functions
branch
from
October 24, 2024 12:37
c60f924
to
190a861
Compare
lorisleiva
force-pushed
the
loris/run-examples-in-ci
branch
from
October 24, 2024 13:15
53d7512
to
6f2b161
Compare
lorisleiva
force-pushed
the
loris/move-bigint-json-functions
branch
from
October 24, 2024 13:16
190a861
to
f46a186
Compare
lorisleiva
force-pushed
the
loris/run-examples-in-ci
branch
from
October 24, 2024 13:18
6f2b161
to
fefae65
Compare
lorisleiva
force-pushed
the
loris/move-bigint-json-functions
branch
from
October 24, 2024 13:18
f46a186
to
6a2da75
Compare
lorisleiva
changed the base branch from
loris/run-examples-in-ci
to
loris/update-failing-example
October 24, 2024 13:18
lorisleiva
force-pushed
the
loris/move-bigint-json-functions
branch
from
October 24, 2024 13:31
6a2da75
to
e58940e
Compare
lorisleiva
changed the base branch from
loris/update-failing-example
to
master
October 24, 2024 13:32
lorisleiva
force-pushed
the
loris/move-bigint-json-functions
branch
2 times, most recently
from
October 24, 2024 15:42
79ebfb7
to
66df5cc
Compare
lorisleiva
force-pushed
the
loris/move-bigint-json-functions
branch
from
October 25, 2024 08:34
66df5cc
to
b831f90
Compare
This was referenced Oct 25, 2024
mcintyre94
approved these changes
Oct 25, 2024
steveluscher
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lorisleiva
force-pushed
the
loris/move-bigint-json-functions
branch
from
October 27, 2024 10:04
b831f90
to
17bdc37
Compare
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
parseJsonWithBigInts
andstringifyJsonWithBigints
functions from therpc-transport-http
package to therpc-spec-types
package in order to reuse them within RPC Subscriptions packages.Note that the library now explicitly re-exports a subset of the
rpc-spec-types
to avoid flooding the namespace with internal type and functions.