Rewrite the legacy token tests without `@solana/spl-token` #2821

steveluscher · 2024-06-14T17:40:30Z

No description provided.

changeset-bot · 2024-06-14T17:40:34Z

⚠️ No Changeset found

Latest commit: 21a7add

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

steveluscher · 2024-06-14T17:40:51Z

An example React app that exercises the new @solana/web3.js and the new Wallet Standard wallet adapter in @solana/react #2817
Repair the type of the chain argument to useSignTransaction and useSignAndSendTransaction #2816
Rewrite the legacy token tests without @solana/spl-token #2821 👈
Fixed a bug where the RPC coalescer would leave the application with no request even though there were consumers #2819 : 1 other dependent PR (#2815 )
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @steveluscher and the rest of your teammates on Graphite

steveluscher · 2024-06-14T17:46:56Z

packages/library-legacy/test/connection.test.ts


        const accountsWithProgramFilter = (
          await connection.getTokenAccountsByOwner(testOwnerKeypair.publicKey, {
            programId: TOKEN_PROGRAM_ID,
          })
        ).value;
-        expect(accountsWithProgramFilter).to.have.length(3);
+        expect(accountsWithProgramFilter).to.have.length(1);


This is not exactly the same as the prior test, but it's close enough. We're not meant to be testing the underlying RPC here.

steveluscher · 2024-06-14T17:49:41Z

pnpm-lock.yaml

-  '@solana/[email protected]([email protected])':
-    dependencies:
-      '@solana/codecs': 2.0.0-preview.2([email protected])
-      '@solana/spl-type-length-value': 0.1.0
-    transitivePeerDependencies:
-      - fastestsmallesttextencoderdecoder
-
-  '@solana/[email protected]([email protected])':
-    dependencies:
-      '@solana/codecs': 2.0.0-preview.2([email protected])
-      '@solana/spl-type-length-value': 0.1.0
-    transitivePeerDependencies:
-      - fastestsmallesttextencoderdecoder
-
-  '@solana/[email protected]([email protected])':
-    dependencies:
-      '@solana/buffer-layout': 4.0.1
-      '@solana/buffer-layout-utils': 0.2.0
-      '@solana/spl-token-group': 0.0.4([email protected])
-      '@solana/spl-token-metadata': 0.1.4([email protected])
-      buffer: 6.0.3
-    transitivePeerDependencies:
-      - fastestsmallesttextencoderdecoder
-
-  '@solana/[email protected]':
-    dependencies:
-      buffer: 6.0.3
-


buffalojoec · 2024-06-14T17:46:56Z

packages/library-legacy/test/connection.test.ts

+        new Uint8Array([
+          153, 120, 247, 45, 160, 119, 144, 219, 220, 209, 73, 91, 210, 102, 31,
+          136, 155, 12, 68, 27, 226, 215, 61, 214, 10, 245, 247, 180, 236, 63,
+          100, 202, 140, 247, 112, 54, 120, 32, 168, 118, 72, 115, 190, 34, 171,
+          126, 15, 119, 252, 173, 50, 173, 8, 10, 96, 239, 21, 32, 94, 67, 37,
+          43, 145, 249,
+        ]),


I'm wondering if this should be a fixture somewhere, like scripts/keypairs.

I at least wrote a comment to note what the pubkey is and where to find the fixture.

buffalojoec · 2024-06-14T17:47:12Z

packages/library-legacy/test/connection.test.ts

+            programId: new PublicKey(
+              'TokenkegQfeZyiNwAJbNbGKPFXCWuBvf9Ss623VQ5DA',
+            ),
+            data: Buffer.from([3, 1, 0, 0, 0, 0, 0, 0, 0]),


Maybe just add a comment here for clarity on the bytes?

buffalojoec · 2024-06-14T17:49:58Z

packages/library-legacy/test/connection.test.ts

+      const payerPublicKey = new PublicKey(
+        '6bffFjUMnnk3tXFJAS8pp9tz6m7oJAd27vm9rKqnLtVv',
+      );


Is this even needed anymore? Looks like no.

It's used in one dumb place and I was too lazy to see if I could replace it. Let me see.

steveluscher · 2024-06-14T18:10:44Z

Merge activity

Jun 14, 11:10 AM PDT: @steveluscher started a stack merge that includes this pull request via Graphite.
Jun 14, 11:11 AM PDT: @steveluscher merged this pull request with Graphite.

github-actions · 2024-07-03T08:02:58Z

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

steveluscher mentioned this pull request Jun 14, 2024

An example React app that exercises the new @solana/web3.js and the new Wallet Standard wallet adapter in @solana/react #2817

Merged

steveluscher force-pushed the 06-14-fixed_a_bug_where_the_rpc_coalescer_would_leave_the_application_with_no_request_even_though_there_were_consumers branch from e572c09 to 341c8b8 Compare June 14, 2024 17:41

steveluscher force-pushed the 06-14_Rewrite_the_legacy_token_tests_without_solana_spl-token branch from e6282c6 to 3513521 Compare June 14, 2024 17:42

steveluscher requested review from buffalojoec and mcintyre94 June 14, 2024 17:42

steveluscher force-pushed the 06-14_Rewrite_the_legacy_token_tests_without_solana_spl-token branch from 3513521 to 9ecc35e Compare June 14, 2024 17:46

steveluscher commented Jun 14, 2024

View reviewed changes

steveluscher force-pushed the 06-14_Rewrite_the_legacy_token_tests_without_solana_spl-token branch from 9ecc35e to 4aa20b3 Compare June 14, 2024 17:48

steveluscher commented Jun 14, 2024

View reviewed changes

buffalojoec reviewed Jun 14, 2024

View reviewed changes

steveluscher force-pushed the 06-14_Rewrite_the_legacy_token_tests_without_solana_spl-token branch 2 times, most recently from 3fef1d9 to ea7da77 Compare June 14, 2024 17:59

Base automatically changed from 06-14-fixed_a_bug_where_the_rpc_coalescer_would_leave_the_application_with_no_request_even_though_there_were_consumers to master June 14, 2024 18:01

steveluscher force-pushed the 06-14_Rewrite_the_legacy_token_tests_without_solana_spl-token branch from ea7da77 to b305df6 Compare June 14, 2024 18:01

Rewrite the legacy token tests without @solana/spl-token

21a7add

steveluscher force-pushed the 06-14_Rewrite_the_legacy_token_tests_without_solana_spl-token branch from b305df6 to 21a7add Compare June 14, 2024 18:02

steveluscher merged commit e1ec67e into master Jun 14, 2024
7 of 8 checks passed

steveluscher deleted the 06-14_Rewrite_the_legacy_token_tests_without_solana_spl-token branch June 14, 2024 18:11

github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rewrite the legacy token tests without `@solana/spl-token` #2821

Rewrite the legacy token tests without `@solana/spl-token` #2821

steveluscher commented Jun 14, 2024

changeset-bot bot commented Jun 14, 2024 •

edited

Loading

steveluscher commented Jun 14, 2024 •

edited

Loading

steveluscher Jun 14, 2024

steveluscher Jun 14, 2024

buffalojoec Jun 14, 2024

steveluscher Jun 14, 2024

buffalojoec Jun 14, 2024

buffalojoec Jun 14, 2024

steveluscher Jun 14, 2024

steveluscher Jun 14, 2024

steveluscher commented Jun 14, 2024 •

edited

Loading

github-actions bot commented Jul 3, 2024

Rewrite the legacy token tests without @solana/spl-token #2821

Rewrite the legacy token tests without @solana/spl-token #2821

Conversation

steveluscher commented Jun 14, 2024

changeset-bot bot commented Jun 14, 2024 • edited Loading

⚠️ No Changeset found

steveluscher commented Jun 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

steveluscher commented Jun 14, 2024 • edited Loading

Merge activity

github-actions bot commented Jul 3, 2024

Rewrite the legacy token tests without `@solana/spl-token` #2821

Rewrite the legacy token tests without `@solana/spl-token` #2821

changeset-bot bot commented Jun 14, 2024 •

edited

Loading

steveluscher commented Jun 14, 2024 •

edited

Loading

steveluscher commented Jun 14, 2024 •

edited

Loading