Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Conversation

steveluscher
Copy link
Contributor

@steveluscher steveluscher commented Jun 14, 2024

Summary

If multiple consumers made the same RPC call, then all of them aborted, then another consumer made the same RPC call, all in the same runloop, you'd end up with zero inflight requests and the remaining callers would never recieve their response.

Copy link

changeset-bot bot commented Jun 14, 2024

🦋 Changeset detected

Latest commit: 341c8b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@solana/rpc Patch
@solana/web3.js-experimental Patch
@solana/rpc-graphql Patch
@solana/transaction-confirmation Patch
@solana/accounts Patch
@solana/addresses Patch
@solana/assertions Patch
@solana/codecs-core Patch
@solana/codecs-data-structures Patch
@solana/codecs-numbers Patch
@solana/codecs-strings Patch
@solana/codecs Patch
@solana/compat Patch
@solana/errors Patch
@solana/fast-stable-stringify Patch
@solana/functional Patch
@solana/instructions Patch
@solana/keys Patch
@solana/options Patch
@solana/programs Patch
@solana/react Patch
@solana/rpc-api Patch
@solana/rpc-parsed-types Patch
@solana/rpc-spec-types Patch
@solana/rpc-spec Patch
@solana/rpc-subscriptions-api Patch
@solana/rpc-subscriptions-spec Patch
@solana/rpc-subscriptions-transport-websocket Patch
@solana/rpc-subscriptions Patch
@solana/rpc-transformers Patch
@solana/rpc-transport-http Patch
@solana/rpc-types Patch
@solana/signers Patch
@solana/sysvars Patch
@solana/transaction-messages Patch
@solana/transactions Patch
@solana/webcrypto-ed25519-polyfill Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor Author

steveluscher commented Jun 14, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @steveluscher and the rest of your teammates on Graphite Graphite

@steveluscher steveluscher force-pushed the 06-14-fixed_a_bug_where_the_rpc_coalescer_would_leave_the_application_with_no_request_even_though_there_were_consumers branch from f83e65a to 6d95510 Compare June 14, 2024 06:40
Copy link
Contributor

@mcintyre94 mcintyre94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice tests too!

Copy link
Contributor

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, nice find!

@steveluscher steveluscher force-pushed the 06-14-fixed_a_bug_where_the_rpc_coalescer_would_leave_the_application_with_no_request_even_though_there_were_consumers branch from 6d95510 to e572c09 Compare June 14, 2024 17:40
@steveluscher steveluscher force-pushed the 06-14-fixed_a_bug_where_the_rpc_coalescer_would_leave_the_application_with_no_request_even_though_there_were_consumers branch from e572c09 to 341c8b8 Compare June 14, 2024 17:41
@steveluscher steveluscher merged commit 7ee47ae into master Jun 14, 2024
7 of 8 checks passed
@steveluscher steveluscher deleted the 06-14-fixed_a_bug_where_the_rpc_coalescer_would_leave_the_application_with_no_request_even_though_there_were_consumers branch June 14, 2024 18:01
Copy link
Contributor

github-actions bot commented Jul 3, 2024

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants