Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Netty's SO_TIMEOUT setting #3579

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Remove Netty's SO_TIMEOUT setting #3579

merged 1 commit into from
Mar 7, 2024

Conversation

kciesielski
Copy link
Member

This setting is not used and causes Netty to print warnings.

@kciesielski kciesielski requested a review from adamw March 7, 2024 10:34
@adamw
Copy link
Member

adamw commented Mar 7, 2024

Not used - it seems it was there in the default config? Don't we want to have a read timeout?

@kciesielski kciesielski marked this pull request as ready for review March 7, 2024 10:39
@kciesielski
Copy link
Member Author

Netty complains that it doesn't recognize SO_TIMEOUT (and it spams with this warning for each newly opened connection), this channel option is probably relevant for different kinds of channels.
For read timeout, we have the requestTimeout setting, which is applied to the ReadTimeoutHandler.

@adamw
Copy link
Member

adamw commented Mar 7, 2024

ah ok :) thanks

@adamw adamw merged commit a967485 into master Mar 7, 2024
28 checks passed
@adamw adamw deleted the remove-netty-so-timeout branch March 7, 2024 12:25
@kciesielski kciesielski linked an issue Apr 5, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Netty warnings
2 participants