-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Netty warnings #3225
Comments
Ran into the exact same issue. I get the same logs when using
and then after 20 seconds (see the timestamps):
I found that in When providing a custom Netty configuration without a socket timeout the warning vanishes:
|
UPDATE: I was actually wrong. Adding the netty configuration only fixes:
But:
still occures. |
In our company we upgraded from tapir 1.2.x to 1.9.x to enjoy the graceful shutdown feature, but these warnings started to show up all of a sudden. So we reverted back to 1.2.x |
UPDATED: I just went back all the versions from 1.9.1 and found that this was introduced in v1.6.1 (changes). With the custom netty settings, as proposed before, all warnings vanish when also setting
I dont know the underlying consequences of it, not even if the warnings are bad. Just wanted to mention it here. If i have time, I will investigate further on this. |
Thoughts and findings after some investigation: The problem stems from I was successful to reproduce the second warning: Some workaround would be to use
|
@amorfis thanks for sharing your findings. I guess you are talking about I set the
but the warning regarding so timeout is still logged:
Now they are logged in the thread Am I missing something? (tested locally on macOS 14.2.1 (23C71)) |
@peterschrott Yes you are right, thank you for pointing out my mistake. You are right that |
Tapir version: 1.7.6
Scala version: 2.13.10
Describe the bug
When using a Netty-based server, the following warnings are logged on every request/response:
How to reproduce?
Use adopt-tapir to generate an example with Netty, run with
sbt run
and make a sample request.Additional information
Tested on an Intel MBP with macOS 14.0
The text was updated successfully, but these errors were encountered: