Graceful Netty server shutdown in case of startup errors #3558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goawash
force-pushed
the
netty-binding-error-shutdown
branch
from
ff5b884 to
035cda1
Compare
|
Thanks! It would be good to include similar improvement for other netty servers (cats, zio, loom). Maybe you could add them to this PR? |
…wash/tapir into netty-binding-error-shutdown
|
Hey @kciesielski, sure, I will try to update those you mentioned as well |
|
Hey @kciesielski! I added support for other Netty-based servers. However, please keep in mind that I don't have too much experience with either Cats or Zio, so I hope I have fixed it correctly there🙂 |
kciesielski
reviewed
Mar 14, 2024
server/netty-server/loom/src/main/scala/sttp/tapir/server/netty/loom/NettyIdServer.scala
Show resolved
Hide resolved
|
@goawash Thanks a lot for this contribution! I just added a small update to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of an error during the start of Netty, e.g., when trying to bind to the same port, the Netty server doesn't release all resources. Due to that, the app's main thread keeps working and cannot gracefully shut down the process entirely. This happens because no resource cleanup is executed, and Event Loop is still working after Netty couldn't be started.
The bug is straightforward to reproduce:
Exception during binding io.netty.channel.unix.Errors$NativeIoException: bind(..) failed: Address already in useThe motivation of this PR is to release allocated resources in case of a failed start of the Netty Server. I have done this fix for all Netty-based servers.