Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Http4sServerRequest.uri #3543

Merged
merged 5 commits into from
Feb 29, 2024
Merged

Optimize Http4sServerRequest.uri #3543

merged 5 commits into from
Feb 29, 2024

Conversation

kciesielski
Copy link
Member

@kciesielski kciesielski commented Feb 29, 2024 •
edited
Loading

Fixes #3546
This PR makes the Http4sServerRequest.uri create the Uri object manually to avoid expensive toString and parsing.

@kciesielski kciesielski changed the title Perf optimizations Optimize Http4sServerRequest.uri Feb 29, 2024
@kciesielski kciesielski linked an issue Feb 29, 2024 that may be closed by this pull request
Optimize Http4sServerRequest.uri #3546
Closed
@kciesielski kciesielski marked this pull request as ready for review February 29, 2024 13:46
@kciesielski kciesielski requested a review from adamw February 29, 2024 13:46
@kciesielski
Copy link
Member Author

@adamw I'm moving the Endpoint optimizations to another PR to keep this focused on http4s.

@kciesielski kciesielski merged commit 1a86175 into master Feb 29, 2024
28 checks passed
@kciesielski kciesielski deleted the fix-perf-log-interceptor branch February 29, 2024 19:59
goawash pushed a commit to goawash/tapir that referenced this pull request Mar 13, 2024
@kciesielski @goawash
Optimize Http4sServerRequest.uri (softwaremill#3543)
32fa9a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamw adamw adamw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize Http4sServerRequest.uri
2 participants
@kciesielski @adamw