Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pekko support #1781

Merged
merged 7 commits into from
Aug 9, 2023
Merged

Conversation

mdedetrich
Copy link
Contributor

@mdedetrich mdedetrich commented Mar 24, 2023

Before submitting pull request:

  • Check if the project compiles by running sbt compile
  • Verify docs compilation by running sbt compileDocs
  • Check if tests pass by running sbt test
  • Format code by running sbt scalafmt

This PR adds initial support for Pekko. Its currently built against snapshots of Pekko as well as a snapshot of sttp-shared (see softwaremill/sttp-shared#276).

Just like with sttp-shared, would be great if a snapshot could be released so that I can add support into tapir https://github.com/softwaremill/tapir

@adamw
Copy link
Member

adamw commented Mar 25, 2023

Version 4.0.0-M1+9-2749c47c-SNAPSHOT should be published to https://s01.oss.sonatype.org/content/repositories/snapshots

@pjfanning pjfanning mentioned this pull request Jul 7, 2023
4 tasks
@mdedetrich
Copy link
Contributor Author

@adamw Pekko Http 1.0.0 was just released if you want to update the versions https://lists.apache.org/thread/cyl51l8xskwyzp61n9t0vcfyb1qpoj9j . A patch release of Pekko was also made (Pekko 1.0.1).

build.sbt Outdated Show resolved Hide resolved
@kciesielski
Copy link
Member

Huge thanks for this contributions @mdedetrich! Looks good to me now, feel free to merge if you consider it complete :)

@kciesielski kciesielski merged commit fc2a11f into softwaremill:master Aug 9, 2023
@mdedetrich mdedetrich deleted the add-pekko-support branch August 9, 2023 08:34
@mdedetrich
Copy link
Contributor Author

Thanks for pushing this through!

kciesielski pushed a commit that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants