Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability for Pekko Streams #276

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

mdedetrich
Copy link
Contributor

@mdedetrich mdedetrich commented Mar 20, 2023

The context of this change is to try and add pekko-http (open source akka fork) to sttp. Currently pekko (and pekko-http) only has snapshots released, the intention behind adding pekko-http to sttp at this stage is to identify if there are any problems before the initial full release.

Due to pekko still being a snapshot and sttp having multiple modules (with sttp-shared being a root module for sttp) I am not entirely sure whats the best way to handle this. You could just merge this PR into master and create a snapshot of sttp-shared but it can be said that this can "pollute" main with a module thats not ready yet. Other alternatives is to make a specific branch for pekko in this git repo which will eventually get merged into master once pekko is ready and you can make snapshot releases of sttp-shared from that pekko branch. Yet another option is to just make sttp-shared snapshots from this PR manually without merging it.

@adamw
Copy link
Member

adamw commented Mar 22, 2023

We don't really do snapshot releases (not sure if that's configured at all ...), but if that would be a blocker for you, I can try :). However, it would much more convenient to have some release, even if it's 0.0.1

@mdedetrich
Copy link
Contributor Author

mdedetrich commented Mar 22, 2023

However, it would much more convenient to have some release, even if it's 0.0.1

So I normally would have zero problem with this, the unfortunate thing is that since Pekko is under ASF there is a lot of process/rigmarole (for good reasons) in making a release even if it just 0.0.1 (i.e. formal voting, vetting etc etc) and the whole idea here is to see if there are any potential problems before a release is made.

@adamw
Copy link
Member

adamw commented Mar 22, 2023

I did try to make a snapshot release from the branch to see if this works at all, but so far sonatype seems to be down, so I'll try later ;)

@mdedetrich
Copy link
Contributor Author

I did try to make a snapshot release from the branch to see if this works at all, but so far sonatype seems to be down, so I'll try later ;)

No worries. Thanks for spending your time doing this, greatly appreciated!

@adamw
Copy link
Member

adamw commented Mar 22, 2023

@mdedetrich
Copy link
Contributor Author

Hm I think this worked ... can you see if https://s01.oss.sonatype.org/content/repositories/snapshots/com/softwaremill/sttp/shared/pekko_2.13/1.3.14+1-51f34857-SNAPSHOT/ is sufficient?

Looks good on my end, able to resolve it in sttp fine. Will open up the main sttp PR and will also do some testing.

Thanks again!

@adamw
Copy link
Member

adamw commented Mar 22, 2023

Great, so I'll leave this PR open, and once we have a non-SNAPSHOT release, we'll be able to merge

@adamw adamw mentioned this pull request May 11, 2023
@adamw adamw merged commit bf1b59b into softwaremill:master Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants