Feat: add scripts to sync archs #2357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoLewicki
reviewed
Jul 19, 2024
maciekstosio
commented
Jul 22, 2024
| @@ -3,7 +3,7 @@ apply plugin: 'com.diffplug.spotless' | |||
|
|
|||
| spotless { | |||
| java { | |||
| target 'src/main/java/**/*.java', 'src/paper/java/com/horcrux/svg/**/*.java' | |||
There was a problem hiding this comment.
Those files at src/paper/java/com/horcrux/svg/ are autogenerated, formatting them messes up checking consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes moved from: software-mansion/react-native-screens#2224
Description
When changing native props on Fabric, codegen generates corresponding interfaces and delegates. To make sure both implementations are consistent, we implement those interfaces on Paper too. Currently, after generating interfaces using codegen, developer needs to copy corresponding files for paper manually. This task adds Gradle task, that automates this.
Changes
Current assumption:
Two scripts:
check-archs-consistencyandsync-archs. The first one generates codegen interfaces and compares them with what we have for paper, the second generates and copies for paper to sync the archs.src/papersrc/paperorandroid/src/paper/java/com/facebook/react/viewmanagerschangesTest code and steps to reproduce
Open
src/fabric/LineNativeComponent.tsor/andsrc/fabric/NativeSvgRenderableModule.tsand remove any proper form interface. Now:Brining back the prop and repeating up should cause the interface back and CI green.
Posting changes in other places should cause CI task to run.
You can also run those commands yourself using
yarn check-archs-consistencyandyarn sync-archs