chore: change gradle task for copying to new archs into JS scripts #2224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
reviewed
Jul 3, 2024
Co-authored-by: Kacper Kafara <[email protected]>
Co-authored-by: Kacper Kafara <[email protected]>
…nges to specififc path/branch
j-piasecki
reviewed
Jul 8, 2024
WoLewicki
reviewed
Jul 8, 2024
| @@ -135,3 +135,13 @@ dependencies { | |||
| } | |||
|
|
|||
| apply from: file("../../node_modules/@react-native-community/cli-platform-android/native_modules.gradle"); applyNativeModulesAppBuildGradle(project) | |||
| apply plugin: 'com.github.node-gradle.node' | |||
|
|
|||
| task syncArchs(type: NodeTask) { | |||
There was a problem hiding this comment.
I don't get it why it's still here. Don't we do everything on the JS side now?
There was a problem hiding this comment.
It's in the app so it shouldn't interfere with the lib. I understood that @kkafar wanted to have it run automatically while developing. It needs to be added per example/test app, so I can just not add it in other packages.
j-piasecki
approved these changes
Jul 9, 2024
kkafar
approved these changes
Jul 9, 2024
| @@ -135,3 +135,13 @@ dependencies { | |||
| } | |||
|
|
|||
| apply from: file("../../node_modules/@react-native-community/cli-platform-android/native_modules.gradle"); applyNativeModulesAppBuildGradle(project) | |||
| apply plugin: 'com.github.node-gradle.node' | |||
|
|
|||
| task syncArchs(type: NodeTask) { | |||
tboba
approved these changes
Jul 9, 2024
Comment on lines
+17
to
+19
| uses: actions/checkout@v2 | ||
| - name: Use Node.js 18 | ||
| uses: actions/setup-node@v2 |
There was a problem hiding this comment.
Let's use v4 script versions.
Suggested change
| uses: actions/checkout@v2 | |
| - name: Use Node.js 18 | |
| uses: actions/setup-node@v2 | |
| uses: actions/checkout@v4 | |
| - name: Use Node.js 18 | |
| uses: actions/setup-node@v4 |
maciekstosio
added a commit
that referenced
this pull request
Jul 23, 2024
## Description Fixes to #2224, that came out in other repos. ## Changes - Bump version of GitHub actions - Fix warning when trying to copy non existing codegen interface ## Test code and steps to reproduce Duplicate `android/src/paper/java/com/facebook/react/viewmanagers/RNSSearchBarManagerDelegate.java` with name change for example with ` copy` at the end. Before it would fail because file wouldn't be found. Now there will be warning in logs.
This was referenced Aug 23, 2024
This was referenced Aug 27, 2024
This was referenced Sep 24, 2024
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
…oftware-mansion#2224) ## Description This task is rewrite to JS of software-mansion#2168 with some improvements. General point of creating those tasks is: > When changing native props on Fabric, codegen generates corresponding interfaces and delegates. To make sure both implementations are consistent, we implement those interfaces on Paper too. Currently, after generating interfaces using codegen, developer needs to copy corresponding files for paper manually. This task adds Gradle task, that automates this. ## Changes Current assumption: Two scripts: `check-archs-consistency` and `sync-archs`. The first one generates codegen interfaces and compares them with what we have for paper, the second generates and copies for paper to sync the archs. - sync is run pre build on example app - sync is run when staged on changes to `src/paper` - check is run on CI when `src/paper` or `android/src/paper/java/com/facebook/react/viewmanagers` changes What it improves: - JS tasks are much faster, as codegen is JS script anyway, we skip gradle and java setup all together (CI task down from 7min to 30s), - we do not put code to library, so it shouldn't be possible to mess up something for end users, - instead of syncing archs when running codegen we do that on paper example build and when staged, so: when developer didn't touch the code it will have changes after commit, when developer switched to working on paper interfaces should be always up to date when building the app. ## Test code and steps to reproduce Open `src/fabric/ScreenStackHeaderConfigNativeComponent.ts` and remove any proper form interface. Now: - when building paper, interface should be updated - when committing, interface should be updated - if committed and pushed, Test consistency between Paper & Fabric should fail :) Brining back the prop and repeating up should cause the interface back and CI green. Posting changes in other places should cause CI task to run. You can also run those commands yourself using `yarn check-archs-consistency` and `yarn sync-archs` --------- Co-authored-by: Kacper Kafara <[email protected]>
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
## Description Fixes to software-mansion#2224, that came out in other repos. ## Changes - Bump version of GitHub actions - Fix warning when trying to copy non existing codegen interface ## Test code and steps to reproduce Duplicate `android/src/paper/java/com/facebook/react/viewmanagers/RNSSearchBarManagerDelegate.java` with name change for example with ` copy` at the end. Before it would fail because file wouldn't be found. Now there will be warning in logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This task is rewrite to JS of #2168 with some improvements. General point of creating those tasks is:
Changes
Current assumption:
Two scripts:
check-archs-consistencyandsync-archs. The first one generates codegen interfaces and compares them with what we have for paper, the second generates and copies for paper to sync the archs.src/papersrc/paperorandroid/src/paper/java/com/facebook/react/viewmanagerschangesWhat it improves:
Test code and steps to reproduce
Open
src/fabric/ScreenStackHeaderConfigNativeComponent.tsand remove any proper form interface. Now:Brining back the prop and repeating up should cause the interface back and CI green.
Posting changes in other places should cause CI task to run.
You can also run those commands yourself using
yarn check-archs-consistencyandyarn sync-archs