Fix AD Accounts with delegation disabled #8688
Conversation
Previously on v4 this was all documented, so i have copied that documentation across to v5
|
Ive also copied across the documentation that was done by @uberbrady |
|
Thanks so much for this! We're reviewing it now. (In the future, please push PRs to |
There was a problem hiding this comment.
Oh, wow, excellent catch @sanjay900 ! Thank you so much. Yes, this logic looks right to me, for sure.
|
Actually, can you retarget this to You don't need to close and re-open. After you create a pull request, you can modify the base branch so that the changes in the pull request are compared against a different branch. By changing the base branch of your original pull request rather than opening a new one with the correct base branch, you’ll be able to keep valuable work and discussion.
Thanks! |
|
Actually, never mind - it's a pretty small change, we'll test it on master. |
|
Congrats on merging your first pull request! 🎉🎉🎉 |
Description
I have some AD accounts that have delegation disabled, and they are then marked as login disabled. This fixes that issue. This was fixed on v4, but the problem has come back on v5 as the fix was not implemented again
The pull requests that fixed this problem on v4
#8111
#8270
Type of change
[x] Bug fix (non-breaking change which fixes an issue)