Fix AD Accounts with delegation disabled #8111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix accounts marked as "Account is sensitive and cannot be delegated", being flagged as disabled due to the useraccountcontrol value not being in the list of values considered being enabled.
|
Is there a reason why there is a hardcoded list of useraccountcontrol values that are considered active instead of just checking that the accountdisable or lockout flags aren't set? There are probably a bunch of other valid useraccountcontrol values that should be considered active but currently are not. |
|
My apologies, I just re-implemented this in #8270 - and I failed to check that you had already fixed this in your PR. I'll close this one out now as a duplicate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a few accounts that we have marked as "Account is sensitive and cannot be delegated", and they were being marked as disabled as the useraccountcontrol value for a sensitive account was not considered an active value. This fixes that by considering those accounts as active.