./config/backup.php hard-coded e-mail placeholder causes errors on backup generation

[Th3Tubby3d]

Please confirm you have done the following before posting your bug report:

• I have enabled debug mode
• I have read checked the Common Issues page

Describe the bug
It appears that line 135 of ./config/backup.php references a hard-coded placeholder ( 'to' => '[email protected]',) instead of configured values from something like https://snipeit.example/admin/notifications ($setting->alert_email maybe?). This is easily fixed by manually modifying the file, but this reverts when upgraded as it doesn't appear it was intended to be directly modified.

To Reproduce
Steps to reproduce the behavior:

1. Go to 'https://snipeit.example/admin/backups'
2. Click on 'Generate Backup' with SMTP configured
3. See error Whoops, looks like something went wrong.

Expected behavior
I believe the intended/expected behavior is to have this value pulled from configuration elsewhere, but it seems to be a placeholder instead.

Screenshots
I believe in this scenario these are unnecessary, but I'll gather some if helpful.

Server (please complete the following information):

• Snipe-IT Version v4.7.3 - build 4098 (master)
• OS: Ubuntu 18.04 Server
• Web Server: Apache
• PHP Version PHP 7.2.17-0ubuntu0.18.04.1

Desktop (please complete the following information):

• OS: OSX
• Browser Chrome, Firefox, Safari
• Version Multiple

Error Messages

• (1/1) Swift_TransportException Expected response code 354 but got code "503", with message "503 5.5.1 Bad sequence of commands " -- in AbstractSmtpTransport.php line 457 at Swift_Transport_AbstractSmtpTransport->assertResponseCode('503 5.5.1 Bad sequence of commands ', array(354))in AbstractSmtpTransport.php line 341 at Swift_Transport_AbstractSmtpTransport->executeCommand('DATA ', array(354), array('[email protected]', '[email protected]', '[email protected]', '[email protected]'), false, null)in EsmtpTransport.php line 305 at Swift_Transport_EsmtpTransport->executeCommand('DATA ', array(354), array('[email protected]', '[email protected]', '[email protected]', '[email protected]'))in AbstractSmtpTransport.php line 390 at Swift_Transport_AbstractSmtpTransport->doDataCommand(array('[email protected]', '[email protected]', '[email protected]', '[email protected]'))in AbstractSmtpTransport.php line 497

Additional context

• Is this a fresh install or an upgrade? upgrade
• What OS and web server you're running Snipe-IT on Ubuntu 18.04 Server Apache
• What method you used to install Snipe-IT (install.sh, manual installation, docker, etc) git
• Include what you've done so far in the installation, and if you got any error messages along the way. see above
• Indicate whether or not you've manually edited any data directly in the database have not

Add any other context about the problem here.

The backup does complete, despite the error. I tried to briefly review to see if it's intended to be replaced during install or something of the like, but was unable to find anything. If this isn't a bug, I apologize.

[snipe]

You can change it to null:

'mail' => [
            'to' => null,
        ],

[snipe]

The fix is now on master. If you'd like to use backup notifications, add this to your .env in the email settings:

[email protected]

(replacing [email protected] with a real address that you want to receive notifications to, of course.)

Then clear your config:

php artisan config:clear

If don't add that line to your .env, no email will be attempted.

[snipe]

(Note that the backup package doesn't actually attach the backup file, it just lets you know that one completed successfully, and notifies you if it didn't complete successfully, so it may or may not be useful, depending on your use-case.)

[snipe]

This is what the notification looks like if you enable them and have a successful backup, btw:

[Th3Tubby3d]

Awesome. Thank you again. I had changed the e-mail address to an appropriate one previously and they were working, but when I upgraded earlier today it reverted, so I figured I would mention it.

[snipe]

No problem - thanks for the heads up!