refactor: patially rewrite code to exctract header info #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create index list in R instead of C++. - Use `size_t` instead of `int` where suitable. - Ensure that correct data types are passed between R and C++. - Use new (own) implementation to extract the acquisition number from the spectrum ID instead of `id::translateNativeIDToScanNumber` from proteowizard to avoid segfaults on macOS (sneumann/xcms#422).
|
This avoids the segfaults on macOS (although pwiz is then stuck at random for a period of time before proceeding - but at least it does no longer break). I haven't tried, but the changes in |
|
Hi, how much of this PR is still relevant ? Yours, Steffen |
|
I think we can close that. Maybe I'll have another look if we encounter some errors in future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
size_tinstead ofintwhere suitable.spectrum ID instead of
id::translateNativeIDToScanNumberfrom proteowizardto avoid segfaults on macOS (Build error on macOS on BioC xcms#422).