-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relative URL isn't appearing in mastodon #390
Comments
Yes! Ideally it should. We'll see how easy it is in practice... |
This isn't looking easy, at least with the tools I have. mf2py fully qualifies URLs it hoists out of content, eg in mf2 properties and rel URLs, but not inside Interestingly, php-mf2 does fully qualify link URLs inside HTML content, eg the avoid it altogether link in https://pin13.net/mf2/?url=https://snarfed.org/2023-01-11_logs-as-end-user-ui . Hmm! That sure would be a nice mf2py feature. cc @sknebel @angelogladding @tommorris @barnabywalters @gRegorLove @aaronpk |
IIRC we implemented this in php-mf2 because it was easy, useful and IMO implied by the mf2 parsing algorithm requiring any other relative URLs to be resolved. Embedded content is presumably going to be reused out of context, and it’s not particularly useful if it contains URLs which were relative to some other context! I agree with Zegnat’s proposal that it get explicitly added to the parsing spec. I’m surprised it hasn’t come up in tests already, to be honest. |
I haven't tested it yet but I think this could also affect #45 in that hashtag URLs need to be absolute to be recognized by Mastodon. |
Sounds like we might get this in mf2py soon! microformats/mf2py#197 (comment) |
This shipped just now in v2.0.1! |
Just re-sent the mention for the original post and I can now see the URL correctly in Mastodon. 👏 |
fixes #390, re microformats/mf2py#181 . thank you again @angelogladding!
I posted a note with a relative URL linking to another page on my site.
However, when this appeared in Mastodon the link was removed. (url for logged in user)
Could bridgy fed convert the relative path to absolute before sending?
The text was updated successfully, but these errors were encountered: