-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next release #197
Comments
@capjamesg merged it after the release, so the release should be ok. The next release should be a major one. I would not spend much time waiting on other changes, having multiple major releases after another doesnt hurt too much for what we do. |
What belongs behind a flag? Currently proposed:
>>> parse(url="example.com", expose_dom=True, block_roots={...}) We decided Should rewriting URLs in |
My ideas around this:
I guess its just strongly proposed, so one could argue both ways about point 3 above. On one hand, its not yet in the spec, on the other hand I suspect its coming and it seems relatively safe. I'd be fine with either, IMHO primarily we should see to get the spec issue resolved. |
I'm excited about all the changes going into this upcoming release! Can't wait to use it. @sknebel++ agreed, release early and often. @capjamesg @angelogladding thanks for all of your renewed interest and work on mf2py! |
I think we are ready to do a release after all active PRs are merged. Special thanks to @angelogladding and @sknebel for reviewing and weighing in on several of the active PRs we had, and for contributing code. @angelogladding Do you want to handle the distribution to PyPi? Rough steps:
|
Let's leave #211 out of the release. I'm not happy with it as is. And I'd like to give the README a little more attention/cleanup as well. |
👍 it can be added in a minor release without issues |
Could we decide on #213 (comment) before the release? I'm ok with any decision. @capjamesg what do you think? |
213 behind a flag could easily be added in a minor release later if we decide to go with it, no need IMHO to hold up the major jump now. |
@capjamesg I think we're good to go for a release. Please add the date to the changelog and regenerate the documentation. Can you add a section in the Makefile for "make docs" while you're at it? |
I left a comment on #213, as I think there may still be a bit more discussion to have before we go ahead with a release. Let's hold off for a day or two to allow more discussion. @angelogladding, documenting your perspective in #213 would be appreciated. |
I've changed my mind on #211. It's actually doing what it's supposed to do right now. I'm hesitating on the hypothetical conflicting property name. If and when a notable discovery is made we can add property-based blocking. |
@angelogladding Does that mean you want to include #211 in the release? |
2.0.1 has been released. |
Amazing! I'm excited to deploy this on my projects. |
The current v1.1.3 will be the final version that supports python2.
As @sknebel points out #182 (comment) we have introduced a breaking change.
Is there any good reason to reverse that (tiny) change and publish a minor release v1.2?
Either way we're on track for a v2.0 major release. Should we kick the tires of our public API while we're at it?
The text was updated successfully, but these errors were encountered: