support custom score api url as function param (and removed unused provider param)

[mktcode]

fixes: #402

Needs adjustments in more places once snapshot.js version gets bumped up.

[ChaituVR]

@bonustrack Removing provider param can be a big change right, It may break for people who already integrated snapshot.js
Maybe we can leave it as it is RN?

[mktcode]

@ChaituVR as long as nobody installs it @master, this shouldn't be a problem. And if you do, you should expect things to changes. Above I also linked a search result for the repos we control, where an update will be needed.

Should then probably be a minor update (not patch), so it will be 0.3.x, since it has breaking changes, right? There are also other refactorings on their way, that will potentially break compatibility with previous versions and could be included in an 0.3 update.

[ChaituVR]

Oops there are conflicts :P

[ChaituVR]

@mktcode This looks good to me, ready to merge this, but the build is failing in GitHub actions with the below error:

src/index.ts → dist/snapshot.min.js...
[!] (plugin rpt2) Error: /home/runner/work/snapshot.js/snapshot.js/src/validations/basic/index.ts(19,26): semantic error TS2554: Expected 6 arguments, but got 4.
src/validations/basic/index.ts
Error: /home/runner/work/snapshot.js/snapshot.js/src/validations/basic/index.ts(19,26): semantic error TS2554: Expected 6 arguments, but got 4.
    at error (/home/runner/work/snapshot.js/snapshot.js/node_modules/rollup/dist/shared/rollup.js:5265:30)
    at throwPluginError (/home/runner/work/snapshot.js/snapshot.js/node_modules/rollup/dist/shared/rollup.js:17956:12)
    at Object.error (/home/runner/work/snapshot.js/snapshot.js/node_modules/rollup/dist/shared/rollup.js:18563:24)
    at Object.error (/home/runner/work/snapshot.js/snapshot.js/node_modules/rollup/dist/shared/rollup.js:18125:38)
    at RollupContext.error (/home/runner/work/snapshot.js/snapshot.js/node_modules/rollup-plugin-typescript2/src/rollupcontext.ts:37:18)
    at lodash_3 (/home/runner/work/snapshot.js/snapshot.js/node_modules/rollup-plugin-typescript2/src/print-diagnostics.ts:41:11)
    at arrayEach (/home/runner/work/snapshot.js/snapshot.js/node_modules/rollup-plugin-typescript2/node_modules/lodash/lodash.js:516:11)
    at _.each (/home/runner/work/snapshot.js/snapshot.js/node_modules/rollup-plugin-typescript2/node_modules/lodash/lodash.js:9342:14)
    at printDiagnostics (/home/runner/work/snapshot.js/snapshot.js/node_modules/rollup-plugin-typescript2/src/print-diagnostics.ts:9:2)
    at Object.transform (/home/runner/work/snapshot.js/snapshot.js/node_modules/rollup-plugin-typescript2/src/index.ts:242:5)

[mktcode]

Yeah I saw that... didn't take a closer look yet. Will do today.

[mktcode]

@mktcode This looks good to me, ready to merge this, but the build is failing in GitHub actions with the below error:

Resolved. I'm not so familiar with TypeScript and the syntax for setting the function param's default values was wrong.

[ChaituVR]

LGTM 👍