Reduce code or complexity

[bonustrack]

Reduce code, remove code duplicate, simplify things, remove unused dependency, if you can reduce code or complexity without removing a feature, feel free to make a PR.

[mktcode]

e.g. getSpaceUri:

https://github.com/snapshot-labs/snapshot/blob/1d5f7839632ce4feb194530b956e9a9c2f57350f/src/helpers/ens.ts#L5

and

https://github.com/snapshot-labs/snapshot-hub/blob/677ef4bd8e5a8e1c4f43cbf00bce02f46d0a4725/src/helpers/ens.ts#L24

can be merged into snapshot.js.

[midgerate]

Some examples.

• Move duplicate code from snapshot-hub / snapshot to snapshot.js
• Use vueuse useStorage https://vueuse.org/core/useStorage/
• Replace ref and computed with $ref and $computed so we no longer need to use .value
• Consider the possibility of using moment.js to work with dates and durations across the code.

[aiinkiestism]

I'll work on this.

[mktcode]

Consider the possibility of using moment.js to work with dates and durations across the code.

We agreed on day.js now: #887

[mktcode]

Also related I'd say: snapshot-labs/snapshot-plugins#20 (comment)
And maybe: #818

[aiinkiestism]

@midgerate

Replace ref and computed with $ref and $computed so we no longer need to use .value

About this, I'm guessing you mean this.
I'm working on it but there are things that can't be replaced.
e.g. use not as a initializer like this.
Plus, declaration as a const is also impossible.
Both invoke error.

Below is my environment.
These are necessary for using Ref Sugar, but I still don't know the result of using much newer version of @vitejs/plugin-vue and @vue/compiler-sfc.

package.json

"@vitejs/plugin-vue": "^1.6.0"
"@vue/compiler-sfc": "^3.2.8"

vite.config.ts

...
plugins: [
    vue({
      // script: {
      //   refSugar: true
      // },
      refTransform: true
    }),
    ...

What do you think?
Btw, I'm just testing this on my local test branch so I can be flexible.

[aiinkiestism]

I've just tested the latest version of @vitejs/plugin-vue and @vue/compiler-sfc.

package.json

---
  "@vitejs/plugin-vue": "^1.9.3",
  "@vue/compiler-sfc": "^3.2.20",
---

Two problems I mentioned in the last comment were still alive, so I think $ref and $computed will be of limited use and for the purpose of keeping code clean and consistent I'm not sure they are helpful right now, if my take is right.

[aiinkiestism]

@bonustrack @mktcode
snapshot-labs/snapshot-plugins#20 (comment)

About this, it seems to me that moving only plugin components to snapshot-plugins means lots of adding, changing of import because it's outside of the path unplugin-vue-components looking at, but is it good?
Sorry and please teach me how if I'm thinking the wrong solution or misunderstanding something.

[mktcode]

Moving the UI components would be part of a more comprehensive refactoring of the plugin mechanic and should be handled in its own issue imho. (Adjusting the unplugin-vue-components config is indeed the approach I'd go for in that case.)

snapshot-labs/snapshot-plugins#20 (comment) is for now just a minimum approach to solve #666 but maybe also kind of a first step in such a refactoring. Just mentioned it as a potential example but maybe the scope of this issue needs to be narrowed down a bit more. Currently it's a bit "infinite".

[aiinkiestism]

I'll just make PRs I've done for now Ready for review.

[midgerate]

This is supposed to be a placeholder for documenting all the ideas for refactoring. There will be separate issues created in due time. Locking this thread.