Emit dns servers in DHCPv4 repr. Fixes #504

[theli-ua]

No description provided.

[theli-ua]

ok, no alloc, right, let me fix that

[theli-ua]

@Dirbaio I have a question re source formatting, it is a bit of a pain that one can't just do rustfmt. Is that intended?

[theli-ua]

all clippy warnings are from code thats already there

[crawford]

@theli-ua do you mind fixing the clippy warnings while you are in here? Regarding rustfmt, the maintainers have a preferred style that isn't easily expressible and have opted to format the code by hand.

[theli-ua]

manual formatting seem to serves as unnecessary friction and deterrent for potential contributions tbh.

I fixed clippy warnings, but really they were all over the place and have nothing to do with the change in this pr

[crawford]

Hmm, that was a much larger fix than I expected. I only saw a single clippy error from e023164 (though, I realize now you mentioned warnings, not errors). I think you can probably drop that last commit from this PR.

[theli-ua]

@crawford I've removed last commit and all checks are passing. Let me know if there is more feedback

[crawford]

Overall, this seems fine to me (might want to squash the commit history in this PR though), but I’m not a maintainer so I must defer to @Dirbaio.

[Dirbaio]

Looks great, thank you!

[theli-ua]

@Dirbaio what's the current approach for 0.7.x maintenance releases?

[Dirbaio]

If you want, send a PR against the v0.7.x branch cherry-picking this change, and I'll release it.

[theli-ua]

@Dirbaio 0.7.x is the branch it was merged into :D

[Dirbaio]

Oh! 🤣

Okay, let me release and cherry-pick into master.

[Dirbaio]

v0.7.5 now out

[Dirbaio]

@theli-ua next time send PRs to master, we later cherry-pick cherrypickable features back to v0.7.x, not the other way around.