Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DHCPRepr doesn't include DNS servers when emitting #504

Closed
theli-ua opened this issue Jun 22, 2021 · 7 comments
Closed

DHCPRepr doesn't include DNS servers when emitting #504

theli-ua opened this issue Jun 22, 2021 · 7 comments
Labels
kind/bug

Comments

@theli-ua
Copy link
Contributor

No description provided.

@theli-ua
Copy link
Contributor Author

Also, why is it always 3 ?????? rfc doesnt restrict amount of servers in any way

@Dirbaio
Copy link
Member

Dirbaio commented Jun 23, 2021

It's 3 because that's the maximum seen in the wild, and since smoltcp is designed to work on systems without alloc we can't simply use a Vec there.

@theli-ua
Copy link
Contributor Author

Would you take PR making Repr<dns: usize> const generic on number of DNS servers?

@Dirbaio
Copy link
Member

Dirbaio commented Jun 23, 2021

The current MSRV is Rust 1.40 which doesn't have const generics.

What's your usecase for supporting more than 3 DNS servers? Maybe we can figure something out.

@theli-ua
Copy link
Contributor Author

I don't have a specific one, was mostly just curious.

@theli-ua
Copy link
Contributor Author

what about alloc feature though? (opt in, backwards compatible)

theli-ua added a commit to theli-ua/smoltcp that referenced this issue Jun 23, 2021
@theli-ua
Emit dns servers in DHCPv4 repr. Fixes smoltcp-rs#504
6d85827
Dirbaio added a commit that referenced this issue Jun 27, 2021
@Dirbaio
Merge pull request #505 from theli-ua/v0.7.x
1d3b3a7 
Emit dns servers in DHCPv4 repr. Fixes #504
@Dirbaio
Copy link
Member

Dirbaio commented Oct 14, 2021

Fixed in #505

@Dirbaio Dirbaio closed this as completed Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug
Milestone
No milestone
Development

No branches or pull requests
2 participants
@theli-ua @Dirbaio