Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove AWS-specfic default user agent #234

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

AllanZhengYP
Copy link
Contributor

Current default user agent string is AWS specific. So the customization
is moved to AWS JS SDK.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Current default user agent string is AWS specific. So the customization
is moved to AWS JS SDK.
@AllanZhengYP AllanZhengYP changed the title remove AWS-specfic default user agent [WIP]remove AWS-specfic default user agent Nov 11, 2020
@kstich
Copy link
Contributor

kstich commented Nov 11, 2020

Should this be set to a value that's just not AWS-specific instead of being removed altogether? What's the resulting behavior when not set in the configuration at all?

@AllanZhengYP
Copy link
Contributor Author

AllanZhengYP commented Dec 13, 2020

@kstich

What's the resulting behavior when not set in the configuration at all?

There won't be a user agent header in the request. The default user agent removed in this change is only the dependency. Currently the components for injecting user agent are scatterred across 2 repos. The middleware that injecting the user agent to the HTTP request lives in the AWS-specific customization. We should either move all the user agent customization to the AWS customization or move the middleware customization to this repo. I think the previous option makes more sense because: (1)It assumes HTTP requests; (2)It depends on servicdId and other AWS-specific configs

@AllanZhengYP AllanZhengYP changed the title [WIP]remove AWS-specfic default user agent remove AWS-specfic default user agent Dec 14, 2020
@kstich kstich merged commit 23d5953 into smithy-lang:master Dec 15, 2020
srchase pushed a commit to srchase/smithy-typescript that referenced this pull request Mar 17, 2023
Current default user agent string is AWS specific. So the customization
is moved to AWS JS SDK.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants