Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]fix(clients-*): update default userAgent #1674

Closed
wants to merge 2 commits into from

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented Nov 10, 2020

Update all the default user agent to comply the metrics standard.

For node.js the default user agent will look like:
aws-sdk-nodejs/3.0.0 linux nodejs/14.3.0 sdk-client/client-s3
browsers:
aws-sdk-js/3.0.0 Gecko Mozilla/5.0 (linux) AppleWebKit/537.36 (KHTML, like Gecko) jsdom/16.2.2 sdk-client/client-s3
react-native:
aws-sdk-js/3.0.0 ReactNative sdk-client/client-s3

/cc @zoewangg

This change also migrate the defaultUserAgent customization to AWS sdk codegen: smithy-lang/smithy-typescript#234

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

codecov-io commented Nov 10, 2020

Codecov Report

Merging #1674 (f9aef09) into master (de75f7e) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #1674    +/-   ##
========================================
  Coverage   79.77%   79.78%            
========================================
  Files         325      331     +6     
  Lines       12087    12587   +500     
  Branches     2553     2678   +125     
========================================
+ Hits         9643    10042   +399     
- Misses       2444     2545   +101     
Impacted Files Coverage Δ
...tocol_tests/aws-restxml/commands/XmlMapsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ocol_tests/aws-restxml/commands/XmlBlobsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ocol_tests/aws-restxml/commands/XmlEnumsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ocol_tests/aws-restxml/commands/XmlListsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...col_tests/aws-restjson/commands/JsonMapsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ol_tests/aws-restjson/commands/JsonBlobsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ol_tests/aws-restjson/commands/JsonEnumsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ol_tests/aws-restjson/commands/JsonListsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...tests/aws-restxml/commands/XmlAttributesCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...tests/aws-restxml/commands/XmlNamespacesCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
... and 130 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f4b7cf...f9aef09. Read the comment docs.

@AllanZhengYP AllanZhengYP changed the title fix(clients-*): update default userAgent [WIP]fix(clients-*): update default userAgent Nov 11, 2020
@AllanZhengYP
Copy link
Contributor Author

Close it as the design changes. Will put up new PR when the implementation update is done.

@trivikr
Copy link
Member

trivikr commented Dec 18, 2020

Superceded by #1775

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants