Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow arbitrary path indexing on input, output tokens #223

Merged
merged 2 commits into from
Oct 21, 2020
Merged

fix: allow arbitrary path indexing on input, output tokens #223

merged 2 commits into from
Oct 21, 2020

Conversation

alexforsyth
Copy link
Contributor

@alexforsyth alexforsyth commented Oct 20, 2020 •
edited by kstich
Loading

Issue #, if available:
Allow one level indexing of input tokens

                "smithy.api#paginated": {
                    "inputToken": "EngineDefaults.Marker",
                    "outputToken": "EngineDefaults.Marker",
                    "items": "EngineDefaults.Parameters",
                    "pageSize": "MaxRecords"
                }

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@alexforsyth alexforsyth force-pushed the alexfors/input-indexing branch from 1199e66 to 20c15dd Compare October 20, 2020 19:24
@trivikr trivikr changed the title fix: allow one level indexing on input tokens fix: allow arbitrary path indexing on input, output tokens Oct 21, 2020
@trivikr trivikr merged commit b13ad0e into smithy-lang:master Oct 21, 2020
@trivikr trivikr mentioned this pull request Oct 21, 2020
Merged
srchase pushed a commit to srchase/smithy-typescript that referenced this pull request Mar 17, 2023
@alexforsyth @srchase
fix: allow arbitrary path indexing on input, output tokens (smithy-la…
44680cb 
…ng#223)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@JordonPhillips JordonPhillips JordonPhillips approved these changes

@mtdowling mtdowling mtdowling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexforsyth @mtdowling @JordonPhillips @trivikr