-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update clients based on smithy-models from 10/16 #1580
Conversation
1964021
to
20e333f
Compare
20e333f
to
6fa2daa
Compare
Updated client post:
|
The CI fails because of the decision of adding The fix for CI failure as of now is to use optional chaining: - token = page["EngineDefaults"]["Marker"];
+ token = page.EngineDefaults?.Marker; |
Codecov Report
@@ Coverage Diff @@
## master #1580 +/- ##
=======================================
Coverage 79.73% 79.73%
=======================================
Files 324 324
Lines 12056 12056
Branches 2547 2547
=======================================
Hits 9613 9613
Misses 2443 2443 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue #, if available:
Internal issue JS-2156
Clients generated based on models updated in #1579
This is a draft PR for testing CI. A new PR would be posted after following PRs are merged:
Description of changes:
update clients based on smithy-models from 10/16
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.