Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update clients based on smithy-models from 10/16 #1580

Merged
merged 3 commits into from
Oct 22, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 16, 2020

Issue #, if available:
Internal issue JS-2156
Clients generated based on models updated in #1579

This is a draft PR for testing CI. A new PR would be posted after following PRs are merged:

Description of changes:
update clients based on smithy-models from 10/16

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr force-pushed the update-clients-10-16 branch from 20e333f to 6fa2daa Compare October 21, 2020 18:26
@trivikr
Copy link
Member Author

trivikr commented Oct 21, 2020

Updated client post:

@trivikr
Copy link
Member Author

trivikr commented Oct 21, 2020

The CI fails because of the decision of adding | undefined in #1124
The decision in #1124 would be undesirable in general for many TypeScript users. We might want to revisit it before GA.

The fix for CI failure as of now is to use optional chaining:

-    token = page["EngineDefaults"]["Marker"];
+    token = page.EngineDefaults?.Marker;

@codecov-io
Copy link

codecov-io commented Oct 21, 2020

Codecov Report

Merging #1580 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1580   +/-   ##
=======================================
  Coverage   79.73%   79.73%           
=======================================
  Files         324      324           
  Lines       12056    12056           
  Branches     2547     2547           
=======================================
  Hits         9613     9613           
  Misses       2443     2443           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76f83f1...9489bdc. Read the comment docs.

@trivikr trivikr marked this pull request as ready for review October 22, 2020 16:43
Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@trivikr trivikr merged commit b10d776 into aws:master Oct 22, 2020
@trivikr trivikr deleted the update-clients-10-16 branch October 22, 2020 16:58
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants