fix(protocols): fix header serde, handle unset union payloads #1417
Conversation
kuhe
force-pushed
the
test/protocols
branch
from
b2e5153 to
4821895
Compare
kuhe
changed the title
kuhe
force-pushed
the
test/protocols
branch
from
4821895 to
89fedbc
Compare
kuhe
changed the title
| Location.PAYLOAD, "data", binding.getMember(), target)); | ||
| } | ||
| ); | ||
| } else { |
There was a problem hiding this comment.
old:
const data: Record<string, any> | undefined = __expectUnion(await parseBody(output.body, context));
contents.nested = de_UnionPayload(data, context);(does not handle empty output correctly)
new:
const data: Record<string, any> | undefined = await parseBody(output.body, context);
if (Object.keys(data ?? {}).length) {
contents.nested = __expectUnion(de_UnionPayload(data, context));
}
kuhe
force-pushed
the
test/protocols
branch
5 times, most recently
from
d757a15 to
d51fec8
Compare
| * @param value - header string value. | ||
| * @returns value split by commas that aren't in quotes. | ||
| */ | ||
| export const splitHeader = (value: string): string[] => { |
There was a problem hiding this comment.
This takes over .split(",") on the deserialization side. Splitting by commas is not enough, because commas within quotes do not count as delimiters, and once split, the items wrapped by double quotes should have those quotes removed.
Behavior specified here: https://github.com/smithy-lang/smithy/blob/main/smithy-aws-protocol-tests/model/restJson1/http-headers.smithy#L229-L232
{
id: "RestJsonInputAndOutputWithQuotedStringHeaders",
documentation: "Tests responses with string list header bindings that require quoting",
protocol: restJson1,
code: 200,
headers: {
"X-StringList": "\"b,c\", \"\\\"def\\\"\", a"
},
params: {
headerStringList: ["b,c", "\"def\"", "a"]
}
}| """, header, value); | ||
| } else { | ||
| writer.write("expect(r.headers[$S]).toBe($S);", header, value); | ||
| } |
There was a problem hiding this comment.
I propose that we ignore comma delimiter spacing rather than changing the upstream Smithy test assertion or our and other language implementations.
There was a problem hiding this comment.
Ah this is a pain. Although wouldn't it be easier to just add a space here?
There was a problem hiding this comment.
should be fine, so I pushed a commit to do so.
kuhe
changed the title
| """, header, value); | ||
| } else { | ||
| writer.write("expect(r.headers[$S]).toBe($S);", header, value); | ||
| } |
There was a problem hiding this comment.
Ah this is a pain. Although wouldn't it be easier to just add a space here?
| return values.map((v) => { | ||
| v = v.trim(); | ||
| const z = v.length; | ||
| if (v[0] === `"` && v[z - 1] === `"`) { |
There was a problem hiding this comment.
Can v be empty? What if there's sequential ,, or , only separated by ws?
There was a problem hiding this comment.
added more test cases to describe what happens, i.e. ,, is 3 empty strings, and so is , , .
this is a set of changes revealed by re-enabling the skipped protocol tests in aws/aws-sdk-js-v3#6512