Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clients): codegen sync for unset union payloads, header list parsing #6543

Merged
merged 7 commits into from
Oct 4, 2024

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Oct 4, 2024

requires:
smithy-lang/smithy-typescript#1417
smithy-lang/smithy-typescript#1426

update codegen to take in protocol test fixes

  • unset union payload
  • header parsing

diff without json files:
https://github.com/aws/aws-sdk-js-v3/pull/6543/files?file-filters%5B%5D=.java&file-filters%5B%5D=.js&file-filters%5B%5D=.lock&file-filters%5B%5D=.ts&show-viewed-files=true#

  • test:protocols
  • test:integration
  • test:e2e
  • test:e2e:legacy

@kuhe
Copy link
Contributor Author

kuhe commented Oct 4, 2024

chore: discard example trashing should say "thrashing", I'll correct it on squash

@kuhe kuhe changed the title chore/protocol tests chore(clients): codegen sync for unset union payloads, header list parsing Oct 4, 2024
@kuhe kuhe force-pushed the chore/protocol-tests branch from ad7be23 to d63767b Compare October 4, 2024 19:17
@kuhe kuhe merged commit 544120e into aws:main Oct 4, 2024
4 checks passed
@kuhe kuhe deleted the chore/protocol-tests branch October 4, 2024 19:36
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants