Escape end of line characters based on 'XML End-Of-Line Encoding' SEP. #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aajtodd
approved these changes
May 14, 2021
| * | `YQ3ChSBiwoU=` | `'a\r\u0085 b\u0085'` | `'a
… b…'` | | ||
| * | `YQ3igKggYsKFIGPigKg=` | `'a\r\u2028 b\u0085 c\u2028'` | `'a

 b… c
'` | | ||
| */ | ||
| // FIXME ~ Unable to add "org.junit.jupiter:junit-jupiter-params" as a test dependency...classes do not resolve |
There was a problem hiding this comment.
comment
or you could just write your own quick loop, something like:
// list of (raw input, expected) pairs
val tests = listOf(
"\n \n" to "
 
",
...
)
tests.forEachIndexed { idx, test -> {
val writer = xmlStreamWriter(pretty = false)
writer.startTag("a")
writer.text(test.first)
writer.endTag("a")
val expected = "<a>${test.second}</a>"
assertEquals(expected, writer.toString(), "test case $idx failed")
}There was a problem hiding this comment.
Yep, that's better I'll update before push.
| @@ -59,7 +59,15 @@ class XmlPullSerializer(pretty: Boolean, private val serializer: XmlSerializer = | |||
| } | |||
|
|
|||
| override fun text(text: String): XmlStreamWriter { | |||
| serializer.text(text) | |||
| text.forEach { character -> | |||
There was a problem hiding this comment.
question
- It looks as though
serializer.text(...)works as "append" if called multiple times? (own clarification) - Is there any performance consideration here?
There was a problem hiding this comment.
- Yes this is my understanding as well. I would expect unit tests to fail if this were not the case after the addition. Here is the library function that appends to the string.
- Yes. Optimistically perhaps not much of an impact as we're simply pulling the linear iteration on each character in the string from inside the xpp library into our code, but there may be things I'm missing. In any case I was unable to think of a cleaner or more performant way of implementing this due to the restrictions in the XPP interface itself. I think the way forward here is to move from XPP to our own implementation.
There was a problem hiding this comment.
sure sounds good. I sort of figured as much
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #142
SEP: /reviews/CR-40585029/revisions/3
NOTE: This PR does not address linefeeds in attribute string values. Discussed this w/ SEP author and believe this needs to be implemented to conform to SEP. However the XPP API does not seem to offer a way of writing raw character values to attributes. So, in order to make this work I believe we'll have to move to another serialize that provides us more control.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.