Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/php8 support #629

Merged
merged 29 commits into from
Oct 13, 2021
Merged

Feature/php8 support #629

merged 29 commits into from
Oct 13, 2021

Conversation

wisskid
Copy link
Contributor

@wisskid wisskid commented Jan 8, 2021 •
edited
Loading

Proposal for a new major, ie Smarty4:

  • Dropped support for PHP7.0 and below, so Smarty 4 runs on PHP7.1, 7.2, 7.3, 7.4 and 8.0
  • Dropped support for php asp tags in templates (removed from php since php7.0)
  • Dropped deprecated API calls that where only accessible through SmartyBC
  • Dropped support for {php} and {include_php} tags and embedded PHP in templates. Embedded PHP will now be passed through as is.

Under the hood:

  • Removed all PHP_VERSION_ID and compare_version checks and conditional code blocks that are now no longer required
  • Switched CI from Travis to Github CI
  • Updated unit tests to avoid skipped and risky test warnings

wisskid and others added 11 commits January 5, 2021 23:56
@wisskid
See if we can get travis to run unit tests on actual php8
277a11a
@wisskid
Dropped suppport for php<7.2 to enable unit testing for php8, using p…
e71481a 
…hpunit8. Updated unit tests for compatability with phpunit8.
@wisskid
Added unit test to confirm #605 was actually fixed
d01f9cd
@wisskid
Test Github CI
7e0d639
@wisskid
switch to default composer
0bca092
@wisskid
Unit test improvements:
7050ff7 
- do not try to test on PHP8.1 in Github CI workflow
- Updated unit test to avoid risky and skipped tests
- Changelog update
- Removed .phpunit.result.cache from CVS and ignore it
@wisskid
Remove all references to travis
24dbbef
@wisskid
Fix phpunit.sh to use phpunit.xml
c665217
@wisskid
Improved php7-style default modifier that does not trigger custom err…
8444ff7 
…or handlers. Fixes #617
@wisskid
Removed all PHP_VERSION_ID and compare_version checks and conditional…
9e394a5 
… code blocks that are now no longer required
@wisskid
Merge branch 'master' into feature/php8-support
886c57d
@wisskid wisskid mentioned this pull request Jan 8, 2021
Closed
@wisskid wisskid mentioned this pull request Jan 8, 2021
Closed
@wisskid
Copy link
Contributor Author

wisskid commented Jan 9, 2021

@uwetews @mohrt @AnrDaemon any thoughts?

@wisskid wisskid mentioned this pull request Jan 9, 2021
Closed
sapics
sapics reviewed Jan 23, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@sapics sapics mentioned this pull request Feb 19, 2021
Closed
@wisskid wisskid mentioned this pull request Mar 21, 2021
Closed
@bkil bkil mentioned this pull request May 1, 2021
Closed
@scottchiefbaker
Copy link

Any updates on this? It's been over six months since this PR was submitted.

sapics and others added 2 commits August 18, 2021 22:41
@sapics
Fix comments and indentation (#637)
c5cc763 
* Fix indentation

* Replace url of smarty.net from http to https

* Fix breaking links

Replace from http://smarty.php.net to https://www.smarty.net

* Replace link from http to https

* Fix CHANGELOG.md
@wisskid
Rename setPHP7CompatMode/getPHP7CompatMode for clarity
867154c
@wisskid wisskid mentioned this pull request Aug 18, 2021
Closed
@scottchiefbaker
Copy link

scottchiefbaker commented Aug 18, 2021 •
edited
Loading

I'm testing this on my site now, and so far things look good. Thanks for updating!

It's worth noting that the version number should be bumped in this testing branch.

@scottchiefbaker
Copy link

Can we get a pre-release or release candidate of version 4.0? I know there are a lot of people who would be interested in testing things against PHP 8.x.

@wisskid wisskid merged commit 39b69f0 into master Oct 13, 2021
@wisskid
Copy link
Contributor Author

wisskid commented Oct 13, 2021

Pre-release published as https://github.com/smarty-php/smarty/releases/tag/v4.0.0-rc.0
Let me know how if you're hitting any bumps testing this!

@wisskid wisskid deleted the feature/php8-support branch October 22, 2021 13:43
xorti pushed a commit to TikiWiki/tiki-manager that referenced this pull request Jan 6, 2022
@marclaporte
Tiki24 LTS has the same requirements as Tiki23. PHP 8.x support will …
2eb2308 
…for sure happen in Tiki25 with Smarty 4.0: smarty-php/smarty#629
@glensc
Copy link
Contributor

glensc commented Jan 10, 2022

does upgrade to 4.x have upgrade guide?

@glensc glensc mentioned this pull request Jan 10, 2022
Draft
@AnrDaemon
Copy link
Contributor

Not at the moment, but we really could use one. Are you up for the task?

@wisskid
Copy link
Contributor Author

wisskid commented Jan 11, 2022

It shouldn't be hard to write, just follow the CHANGELOG line by line.

@glensc
Copy link
Contributor

glensc commented Jan 12, 2022

I ran into such problem:

so, I guess it involves some portion of trial and error.

@ytake ytake mentioned this pull request Feb 11, 2022
Merged
This was referenced Sep 22, 2022
Closed
Closed
@wisskid wisskid restored the feature/php8-support branch August 6, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapics sapics sapics left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wisskid @scottchiefbaker @glensc @AnrDaemon @sapics