Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huge amount of warnings on PHP8 #648

Closed
noximo opened this issue Mar 18, 2021 · 4 comments
Closed

Huge amount of warnings on PHP8 #648

noximo opened this issue Mar 18, 2021 · 4 comments

Comments

@noximo
Copy link

noximo commented Mar 18, 2021

We recently switched to PHP8. Smarty works fine but generates a lot of warnings due to missing variables. I know that Smarty 4 will have setting to deal with this and that it is supposed to be released soon-ish but I would like to know if there's some solution I can try in the meantime to keep the log folders clean.

@redcuillin
Copy link

sudo apt-get install php7.4?

I know that sounds flippant, and I don't mean to sound unfriendly. But if Smarty doesn't support PHP8 yet, why are you using it with PHP8? PHP8 is very new, and huge amounts of code used widely in website dependencies has not transitioned yet. PHP7.4 is still fully supported and there are no security concerns. The simplest answer is 'be patient' before rushing to install PHP8 in a production environment.

If you must have 8, and Smarty works barring the warnings, fork it and fix the unset variables yourself. Or turn off PHP warnings (you can still get more serious errors logged) in php.ini.

@noximo
Copy link
Author

noximo commented Mar 21, 2021

fork it and fix the unset variables yourself

That's what I wanted to do. I was hoping someone would point me in a direction where I can fix it, because the errors themselves are in the generated files

@wisskid
Copy link
Contributor

wisskid commented Mar 21, 2021

Maybe you can give the feature/php8-support branch? You can see it here #629

@wisskid
Copy link
Contributor

wisskid commented Mar 21, 2021

Closing this as a duplicate of #605

@wisskid wisskid closed this as completed Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants