Sensor Services #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This takes use of ros2 services to communicate and send instructions/commands to the sensors
|
We are able to configure the IP address of the sensor providing a separate service for it. In order to successfully configure the IP address , after executing the service the sensor and the node must be restarted with the new sensor_ip value in the radar_param file. Could be done with the following call: The value of the IP address must be a |
JWhitleyWork
suggested changes
Jan 26, 2022
umrr_ros2_driver/include/umrr_ros2_driver/smartmicro_radar_node.hpp
Outdated
Show resolved
Hide resolved
@JWhitleyWork Thanks for your review, I will look into it in detail and make the required changes. |
ghost
removed a link to an issue
…es from Dockerfile
Closed
One simulator which would be used to simulated different sensor types. A new param model introduced which specificies the sesnor to be used. Compose file adopted to run multiple simulators.
Running two services parallel with the same build seem to cause issues and therefore a new service is created. Docker exits as build service exits and does not continue forward hence a timer for port streamer introduced. Readme and actions file adopted respectively
Binaries unpacked only inside the umrr_ros2_driver directory and the simulator adopted to find the binaries. Formatting and grammar checks.
Timer callbacks introduced, checks for instructions and function to handle responses from sensors.
Check for instructions, extended test to include service calls and servie checks
Detailed description of usage of the ros2 services provided by the node
smartEBL
requested review from
smartBUILDBOT
and removed request for
smartBUILDBOT
smartBUILDBOT
approved these changes
Jun 2, 2022
ghost
pushed a commit
that referenced
this pull request
Jun 2, 2022
Provide ros2 services to change sensor modes and configure the sensor
smartBUILDBOT
pushed a commit
that referenced
this pull request
Jun 2, 2022
Provide ros2 services to change sensor modes and configure the sensor
smartBUILDBOT
pushed a commit
that referenced
this pull request
Jun 2, 2022
Provide ros2 services to change sensor modes and configure the sensor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to take use of ros services issue #3 to communicate and send instructions/commands to the sensors. The umrr sensors come with different operation modes and features which could be accessed through the services.