Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keepContextAvailable parameter #887

Merged
merged 4 commits into from
Oct 3, 2018

Conversation

bilal-alsharifi
Copy link
Contributor

Fixes #624

This PR is ready for review.

Risk

This PR makes minor API changes.

Testing Plan

  • Updated the current unit tests and added the new param

Summary

This PR adds the missing keepContextAvailable param to AudioControlCapabilities as described in this proposal revisions.

CLA

@codecov-io
Copy link

Codecov Report

Merging #887 into develop will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #887      +/-   ##
=============================================
+ Coverage      42.42%   42.45%   +0.03%     
- Complexity      3704     3706       +2     
=============================================
  Files            433      433              
  Lines          22942    22949       +7     
  Branches        2660     2661       +1     
=============================================
+ Hits            9733     9744      +11     
+ Misses         12578    12572       -6     
- Partials         631      633       +2
Impacted Files Coverage Δ Complexity Δ
...om/smartdevicelink/proxy/rpc/AudioControlData.java 100% <ø> (ø) 10 <0> (ø) ⬇️
...devicelink/proxy/rpc/AudioControlCapabilities.java 88% <100%> (+1.63%) 14 <2> (+2) ⬆️
...in/java/com/smartdevicelink/util/AndroidTools.java 6.25% <0%> (-0.57%) 1% <0%> (ø)
...smartdevicelink/encoder/VirtualDisplayEncoder.java 29.31% <0%> (+4.59%) 8% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 300a042...9d8c1d8. Read the comment docs.

@joeygrover joeygrover merged commit 13e0423 into develop Oct 3, 2018
@joeygrover joeygrover deleted the feature/add_keepContextAvailable branch October 3, 2018 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants