Revise SDL-0099 - Add a keepContextAvailable parameter and fix typos #601
Conversation
|
@theresalech it is ready for review. thank you. |
There was a problem hiding this comment.
@yang1070 I found one typo in the proposal file that should be fixed. Additionally, can you please update the Impact on Existing Code section of the PR description to call out that both the Android and iOS implementations of this feature will also need to be updated to include this new parameter, and update the reference to the proposal number in the PR title and Introduction section of the description to SDL-0099?
| @@ -240,6 +240,9 @@ New AUDIO data types. | |||
| <param name="sourceAvailable" type="Boolean" mandatory="false"> | |||
| <description>Availability of the control of audio source. </description> | |||
| </param> | |||
| <param name="keepContextAvailable" type="Boolean" mandatory="false"> | |||
| <description>Availability of the keepContext paramter. </description> | |||
There was a problem hiding this comment.
Please fix typo "parameter"
There was a problem hiding this comment.
@theresalech updated, thanks
theresalech
changed the title
theresalech
added
java suite
ios
core
rpc
review ready
review revision update
hmi
labels
|
The Steering Committee voted to accept this PR with the following revision: include default value (defValue) in parameter line for |
|
@yang1070 please advise when PR has been updated per agreed upon revision. We'll then merge so that SDL 0099 is up to date. |
|
@theresalech |
Introduction
Proposal SDL-0099 has some issues:
keepContextAvailableis missing in theAudioControlCapabilities. It is used to tell the mobile applications that the vehicle can support parameterkeepContextor not. Usually, for each controllable parameter, there is an available parameter in the capabilities. AndkeepContextAvailableis missing.keepContext.Motivation
Fix the issues.
Proposed solution
Add a new
keepContextAvailableparameter toAudioControlCapabilities.Update the description of parameter
keepContext.Potential downsides
None the author could identify.
Impact on existing code
RPC (mobile_api and hmi_api) spec shall be updated.
Android and iOS implementations will also need to be updated to include this new parameter.
Since this is an update to the accepted but not released proposal, the impact shall be minimum.
Alternatives considered
No alternatives were considered.