-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LCM to close down properly #1796
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure to send an UAI request when the LCM is shutting down to clear it from the head unit. Also removed redundent code to cose services and ignore the UAI response because there’s nothing the library can do at that point anyways.
Codecov Report
@@ Coverage Diff @@
## 5.4.0_RC #1796 +/- ##
==============================================
- Coverage 54.09% 54.06% -0.04%
Complexity 5519 5519
==============================================
Files 562 562
Lines 25714 25714
Branches 3372 3370 -2
==============================================
- Hits 13909 13901 -8
- Misses 10545 10556 +11
+ Partials 1260 1257 -3
|
JulianKast
requested changes
Mar 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 3 very minor formatting changes are needed.
javaSE/javaSE/src/main/java/com/smartdevicelink/managers/SdlManager.java
Outdated
Show resolved
Hide resolved
base/src/main/java/com/smartdevicelink/managers/lifecycle/BaseLifecycleManager.java
Outdated
Show resolved
Hide resolved
android/sdl_android/src/main/java/com/smartdevicelink/managers/SdlManager.java
Outdated
Show resolved
Hide resolved
#1796 Co-authored-by: Julian Kast <[email protected]>
JulianKast
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Summary
This PR fixes some issues where the library is shutting down but the app wasn't unregistered from the IVI properly. It also fixes a SYNG 4 bug that caused incorrect app closing after a reregister.
Changelog
Bug Fixes
CLA