Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu Manager won't send submenu cell images on RPC versions >= 5.0 && < 7.0 #1759

Merged
merged 8 commits into from
Nov 22, 2021

Conversation

bilal-alsharifi
Copy link
Contributor

@bilal-alsharifi bilal-alsharifi commented Oct 25, 2021

Fixes #1756

This PR is [ready] for review.

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
  • I have tested Android, Java SE, and Java EE

Unit Tests

Included new unit tests for WindowCapabilitySupportsPrimaryImage()

Core Tests:

Tested creating a menu cell w/ subcells with an image

Core version tested against: 8.0.0
HMI version tested against: Generic HMI 0.11.0

Summary

This PR makes two changes:

  1. It will now add the AddSubmenu (menu cell w/ subcells) primary image on RPC connections >= 5.0 and < 7.0 because we don't have an image field name that corresponds to that image support.
  2. It will now only upload menu cell images that are supported by the current window capability, which should be the same at all times.

CLA

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #1759 (a627e9e) into develop (0bda034) will increase coverage by 0.03%.
The diff coverage is 68.75%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1759      +/-   ##
=============================================
+ Coverage      54.37%   54.40%   +0.03%     
- Complexity      5498     5508      +10     
=============================================
  Files            562      562              
  Lines          25466    25477      +11     
  Branches        3317     3318       +1     
=============================================
+ Hits           13847    13861      +14     
+ Misses         10360    10359       -1     
+ Partials        1259     1257       -2     
Impacted Files Coverage Δ
...ink/managers/screen/menu/MenuReplaceOperation.java 53.64% <66.66%> (+0.03%) ⬆️
...ink/managers/screen/menu/MenuReplaceUtilities.java 68.49% <69.23%> (+1.01%) ⬆️
...rtdevicelink/streaming/video/SdlRemoteDisplay.java 52.43% <0.00%> (+1.21%) ⬆️
...rc/main/java/com/smartdevicelink/util/Version.java 86.79% <0.00%> (+1.88%) ⬆️
...nk/managers/audio/AudioDecoderCompatOperation.java 79.54% <0.00%> (+4.54%) ⬆️

# Conflicts:
#	base/src/main/java/com/smartdevicelink/managers/screen/menu/MenuReplaceUtilities.java
@bilal-alsharifi bilal-alsharifi changed the base branch from release/5.3.0_RC to develop October 29, 2021 17:40
@bilal-alsharifi bilal-alsharifi changed the title Menu Manager won't send submenu cell images on RPC versions >= 5.0 && < 7.1 Menu Manager won't send submenu cell images on RPC versions >= 5.0 && < 7.0 Nov 8, 2021
@bilal-alsharifi bilal-alsharifi merged commit b1bf822 into develop Nov 22, 2021
@bilal-alsharifi bilal-alsharifi deleted the bugfix/issue_1756 branch November 22, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants