-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Menu Manager won't send submenu cell images on RPC versions >= 5.0 && < 7.0 #1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1759 +/- ##
=============================================
+ Coverage 54.37% 54.40% +0.03%
- Complexity 5498 5508 +10
=============================================
Files 562 562
Lines 25466 25477 +11
Branches 3317 3318 +1
=============================================
+ Hits 13847 13861 +14
+ Misses 10360 10359 -1
+ Partials 1259 1257 -2
|
# Conflicts: # base/src/main/java/com/smartdevicelink/managers/screen/menu/MenuReplaceUtilities.java
JulianKast
approved these changes
Nov 1, 2021
bilal-alsharifi
changed the title
Menu Manager won't send submenu cell images on RPC versions >= 5.0 && < 7.1
Menu Manager won't send submenu cell images on RPC versions >= 5.0 && < 7.0
Nov 8, 2021
JulianKast
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1756
This PR is [ready] for review.
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
Included new unit tests for
WindowCapabilitySupportsPrimaryImage()
Core Tests:
Tested creating a menu cell w/ subcells with an image
Core version tested against: 8.0.0
HMI version tested against: Generic HMI 0.11.0
Summary
This PR makes two changes:
CLA