Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu Manager won't send submenu cell images on RPC versions >= 5.0 && < 7.0 #2047 #1756

Closed
bilal-alsharifi opened this issue Oct 21, 2021 · 0 comments
Closed

Menu Manager won't send submenu cell images on RPC versions >= 5.0 && < 7.0 #2047 #1756

bilal-alsharifi opened this issue Oct 21, 2021 · 0 comments
Labels
bug A defect in the library

Comments

@bilal-alsharifi
Copy link
Contributor

bilal-alsharifi commented Oct 21, 2021 •
edited
Loading

Bug Report

SDL added support for submenu cell images on v5.0 but didn't add an image field name until v7.0. When connecting to systems on or above v5.0 and below v7.0, we must send the submenu icon even if the image field name isn't there.

Reproduction Steps
  1. Connect to a >= v5.0 && < v7.0 Core and HMI that supports submenu icons
  2. Show a submenu cell with an image
Expected Behavior

The image appears

Observed Behavior

The image does not appear

OS & Version Information
  • Android Version: N/A
  • SDL Android Version: 5.3 RC
  • Testing Against: N/A
@joeljfischer joeljfischer changed the title Menu Manager won't send submenu cell images on RPC versions >= 5.0 && < 7.0 #2047 Menu Manager won't send submenu cell images on RPC versions >= 5.0 && < 7.1 #2047 Oct 25, 2021
bilal-alsharifi added a commit that referenced this issue Oct 25, 2021
@bilal-alsharifi
Fix issue #1756
445c576
@bilal-alsharifi bilal-alsharifi mentioned this issue Nov 8, 2021
Merged
5 tasks
@bilal-alsharifi bilal-alsharifi changed the title Menu Manager won't send submenu cell images on RPC versions >= 5.0 && < 7.1 #2047 Menu Manager won't send submenu cell images on RPC versions >= 5.0 && < 7.0 #2047 Nov 8, 2021
@jordynmackool jordynmackool added the bug A defect in the library label Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A defect in the library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bilal-alsharifi @jordynmackool