Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SecurityQueryPayload to include json data #1758

Merged
merged 8 commits into from
Nov 22, 2021
Merged

Conversation

RHenigan
Copy link
Contributor

@RHenigan RHenigan commented Oct 25, 2021

Fixes #1753

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
  • I have tested Android

Unit Tests

Updated SecurityQuery Unit Tests

Core Tests

Verify Encryption Still works.
---and---
Force sendHandshake to fail and verify the library has the json payload set with the error message information

Core version / branch / commit hash / module tested against: Core 8.0
HMI name / version / branch / commit hash / module tested against: Sdl HMI 5.6

Summary

This PR updates SecurityQueryPayload implementation to make sure the JSON data and error Byte are set when responding with an error notification to Core

CLA

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #1758 (f094e56) into release/5.3.0_RC (92b8ccb) will increase coverage by 0.08%.
The diff coverage is 30.30%.

Impacted file tree graph

@@                  Coverage Diff                   @@
##             release/5.3.0_RC    #1758      +/-   ##
======================================================
+ Coverage               54.37%   54.46%   +0.08%     
- Complexity               5498     5558      +60     
======================================================
  Files                     562      562              
  Lines                   25464    25592     +128     
  Branches                 3316     3364      +48     
======================================================
+ Hits                    13847    13939      +92     
- Misses                  10359    10387      +28     
- Partials                 1258     1266       +8     
Impacted Files Coverage Δ
...va/com/smartdevicelink/session/BaseSdlSession.java 16.66% <0.00%> (-2.09%) ⬇️
...smartdevicelink/protocol/SecurityQueryPayload.java 73.07% <74.07%> (+3.72%) ⬆️
...rtdevicelink/streaming/video/SdlRemoteDisplay.java 50.00% <0.00%> (-1.22%) ⬇️
...nk/managers/audio/AudioDecoderCompatOperation.java 79.54% <0.00%> (+4.54%) ⬆️
...ink/managers/screen/menu/MenuReplaceUtilities.java 73.46% <0.00%> (+5.33%) ⬆️

@RHenigan RHenigan changed the base branch from release/5.3.0_RC to develop November 22, 2021 14:46
@RHenigan RHenigan merged commit 423836c into develop Nov 22, 2021
@RHenigan RHenigan deleted the bugfix/issue_1753 branch November 22, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants