Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecurityQuery error notification payload not set #1753

Closed
RHenigan opened this issue Oct 18, 2021 · 0 comments
Closed

SecurityQuery error notification payload not set #1753

RHenigan opened this issue Oct 18, 2021 · 0 comments
Labels
5.3 Release Issues introduced by 5.3 release candidate

Comments

@RHenigan
Copy link
Contributor

Bug Report

When the library needs to send an error notification back to core in the even the sendHandshake fails the security query header is set but the payload is not. The payload need the jsonData and errorCode set as detailed in the documentation linked below

https://github.com/smartdevicelink/protocol_spec/tree/release/5.4.1#51143-error-codes

Reproduction Steps

We need a situation where the handshake fails, we can emulate this with the below change

  1. force iNumBytes to be null
  2. Add logs to BaseSdlSession.processControlService() to log the final protocolMessage
  3. Trigger a PTU
Expected Behavior

The SecurityQuery Header and Payload should be set as detailed below:

QueryID(SecurityQueryID.SEND_INTERNAL_ERROR);
QueryType(SecurityQueryType.NOTIFICATION);
CorrelationID(msg.getCorrID());
JsonSize(SIZE OF JSON DATA);
JsonData({"id": <error_code>, "text": <error_message>});
ErrorCodeByte(Corresponding byte to the error message);

Observed Behavior

The SecurityQuery Header is set but not the payload:
QueryID(SecurityQueryID.SEND_INTERNAL_ERROR);
QueryType(SecurityQueryType.NOTIFICATION);
CorrelationID(msg.getCorrID());
JsonSize(SIZE OF JSON DATA);

OS & Version Information
  • Android Version: SDK 30
  • SDL Android Version: RC_5.3.0
  • Testing Against: Core 8.0.0
@theresalech theresalech added the 5.3 Release Issues introduced by 5.3 release candidate label Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.3 Release Issues introduced by 5.3 release candidate
Projects
None yet
Development

No branches or pull requests

2 participants