You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the library needs to send an error notification back to core in the even the sendHandshake fails the security query header is set but the payload is not. The payload need the jsonData and errorCode set as detailed in the documentation linked below
We need a situation where the handshake fails, we can emulate this with the below change
force iNumBytes to be null
Add logs to BaseSdlSession.processControlService() to log the final protocolMessage
Trigger a PTU
Expected Behavior
The SecurityQuery Header and Payload should be set as detailed below:
QueryID(SecurityQueryID.SEND_INTERNAL_ERROR);
QueryType(SecurityQueryType.NOTIFICATION);
CorrelationID(msg.getCorrID());
JsonSize(SIZE OF JSON DATA);
JsonData({"id": <error_code>, "text": <error_message>});
ErrorCodeByte(Corresponding byte to the error message);
Observed Behavior
The SecurityQuery Header is set but not the payload:
QueryID(SecurityQueryID.SEND_INTERNAL_ERROR);
QueryType(SecurityQueryType.NOTIFICATION);
CorrelationID(msg.getCorrID());
JsonSize(SIZE OF JSON DATA);
OS & Version Information
Android Version: SDK 30
SDL Android Version: RC_5.3.0
Testing Against: Core 8.0.0
The text was updated successfully, but these errors were encountered:
Bug Report
When the library needs to send an error notification back to core in the even the sendHandshake fails the security query header is set but the payload is not. The payload need the jsonData and errorCode set as detailed in the documentation linked below
https://github.com/smartdevicelink/protocol_spec/tree/release/5.4.1#51143-error-codes
Reproduction Steps
We need a situation where the handshake fails, we can emulate this with the below change
BaseSdlSession.processControlService()
to log the final protocolMessageExpected Behavior
The SecurityQuery Header and Payload should be set as detailed below:
QueryID(SecurityQueryID.SEND_INTERNAL_ERROR);
QueryType(SecurityQueryType.NOTIFICATION);
CorrelationID(msg.getCorrID());
JsonSize(SIZE OF JSON DATA);
JsonData({"id": <error_code>, "text": <error_message>});
ErrorCodeByte(Corresponding byte to the error message);
Observed Behavior
The SecurityQuery Header is set but not the payload:
QueryID(SecurityQueryID.SEND_INTERNAL_ERROR);
QueryType(SecurityQueryType.NOTIFICATION);
CorrelationID(msg.getCorrID());
JsonSize(SIZE OF JSON DATA);
OS & Version Information
The text was updated successfully, but these errors were encountered: