Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC spec generator no longer generates unused SDLRPCParameterNames #1917

Merged

Conversation

NicoleYarroch
Copy link
Contributor

@NicoleYarroch NicoleYarroch commented Feb 12, 2021

Fixes #1905

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

RPC Spec generator tests were updated and run.

Core Tests

The library was not modified. Only the RPC Spec generator was modified.

Core version / branch / commit hash / module tested against: N/A
HMI name / version / branch / commit hash / module tested against: N/A

Summary

Fixed the RPC Spec generator so it no longer generates a SDLRPCParameterName enum for a struct name.

Changelog

Bug Fixes
  • RPC spec generator no longer generates unused SDLRPCParameterNames

CLA

Updated tests to make sure a name is generated for a struct that is a parameter in another struct

Signed-off-by: NicoleYarroch <[email protected]>
@NicoleYarroch NicoleYarroch added bug A defect in the library rpc-spec-generator Relating to the RPC spec generator labels Feb 12, 2021
@NicoleYarroch NicoleYarroch self-assigned this Feb 12, 2021
@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #1917 (9a93e69) into develop (0f8d099) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1917   +/-   ##
========================================
  Coverage    84.93%   84.93%           
========================================
  Files          426      426           
  Lines        21383    21383           
========================================
+ Hits         18161    18162    +1     
+ Misses        3222     3221    -1     

@joeljfischer joeljfischer merged commit ac0f68a into develop Feb 23, 2021
@joeljfischer joeljfischer deleted the bugfix/generator/issue_1905_rpc_param_names_for_structs branch February 23, 2021 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library rpc-spec-generator Relating to the RPC spec generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RPC spec generator creates unnecessary parameter names for structs
2 participants