Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC spec generator creates unnecessary parameter names for structs #1905

Closed
NicoleYarroch opened this issue Jan 28, 2021 · 0 comments · Fixed by #1917
Closed

RPC spec generator creates unnecessary parameter names for structs #1905

NicoleYarroch opened this issue Jan 28, 2021 · 0 comments · Fixed by #1917
Assignees
Labels
bug A defect in the library rpc-spec-generator Relating to the RPC spec generator

Comments

@NicoleYarroch
Copy link
Contributor

Bug Report

RPC spec generator creates unnecessary parameter names in the SDLRPCParameterNames file for structs. For example, the SDLRPCParameterNameChoice is created for the SDLChoice struct. This generated parameter name is not used anywhere in the code base.

In some cases, the correct parameter name is created with the wrong capitalization. For example, this is what is generated for the appInfo parameter:

SDLRPCParameterName const SDLRPCParameterNameAppInfo = @"AppInfo";

when it should be:

SDLRPCParameterName const SDLRPCParameterNameAppInfo = @"appInfo";

I believe this is happening because there is an SDLAppInfo struct and an appInfo parameter.

Reproduction Steps
  1. Set the .gitmodule to use the develop branch of the RPC spec.
  2. Run the generator script in the generator folder of the library.
Expected Behavior

No parameter names should be generated for structs.

Observed Behavior

Unused parameter names are being generated

OS & Version Information
  • iOS Version: n/a
  • SDL iOS Version: 7.0
  • Testing Against: n/a
@NicoleYarroch NicoleYarroch added bug A defect in the library rpc-spec-generator Relating to the RPC spec generator labels Jan 28, 2021
@NicoleYarroch NicoleYarroch self-assigned this Jan 28, 2021
@NicoleYarroch NicoleYarroch linked a pull request Feb 12, 2021 that will close this issue
4 tasks
@joeljfischer joeljfischer mentioned this issue Mar 15, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library rpc-spec-generator Relating to the RPC spec generator
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants