Handle nil displayCapabilities better in SCM #1664
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1623
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
Core Tests
Core version / branch / commit hash / module tested against:
HMI name / version / branch / commit hash / module tested against:
Summary
This PR updates the SCM and screen sub-managers to better handle when
displayCapabilities == nil
to construct theimageFields
andtextFields
to be fully capable. Then whendisplayCapabilities.imageFields == nil
anddisplayCapabilities.textFields == nil
while thedisplayCapabilities
struct itself is notnil
, then allimageFields
andtextFields
are assumed to be unsupported.Changelog
Bug Fixes
displayCapabilities.imageFields
ordisplayCapabilities.textFields
isnil
intentionally, the head unit believes that everything is supported.Tasks Remaining:
CLA