Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move textFields / imageFields == nil checking from ScreenManager to SystemCapabilityManager #1623

Closed
joeljfischer opened this issue Apr 9, 2020 · 0 comments
Closed

Move textFields / imageFields == nil checking from ScreenManager to SystemCapabilityManager #1623

joeljfischer opened this issue Apr 9, 2020 · 0 comments
Assignees
@joeljfischer
Labels
bug A defect in the library manager-screen Relating to the manager layer - screen managers manager-system-capability Relating to the manager layer - system capability

Comments

@joeljfischer
Copy link
Contributor

Bug Report

Currently we have logic in the screen manager that checks if textFields or imageFields is nil. If it is, it assumes everything is available. We should remove this checking. Instead, the SCM should check if a displayCapabilities coming in is nil. If it is, construct a textFields and imageFields with everything, or keep all current capabilities. This will eliminate a possible bug where displayCapabilities exists, but textFields / imageFields is intentionally nil.
@joeljfischer joeljfischer added bug A defect in the library manager-screen Relating to the manager layer - screen managers manager-system-capability Relating to the manager layer - system capability labels Apr 9, 2020
This was referenced Apr 9, 2020
Closed
Closed
@joeljfischer joeljfischer self-assigned this May 18, 2020
@joeljfischer joeljfischer mentioned this issue May 20, 2020
Merged
9 tasks
@joeljfischer joeljfischer mentioned this issue Jul 9, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joeljfischer joeljfischer

Labels
bug A defect in the library manager-screen Relating to the manager layer - screen managers manager-system-capability Relating to the manager layer - system capability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joeljfischer