Remove the delay on data sessions #1549
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This means that multi-session connections will not be delayed
joeljfischer
added
bug
|
@kshala-ford @mrapitis This PR removes the data session delay, which was planned for v6.4.0 but removed due to concerns. Please do additional testing with it if you can, it would be nice to add it to the v6.6.0 or v6.7.0 release this year. |
|
@joeljfischer thank you. I was going to get in contact with you about this PR. My observations from testing were that the first versions with multisession suffer the most compared to the most recent builds to be practically not affected at all. We will do some more thorough testing to confirm. Eventually we can reduce the delay for head units running Core 4.x and immediately connect on Core 5 and higher (expecting that identifying Core is possible with EAAccessory data only). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1240
Recreates #1385, which was reverted
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Smoke tests were performed with the following scenarios:
Summary
This PR updates the IAP transport to only delay apps from connecting with their retry delay when the control session is being used for connection, not when the multisession protocol (direct to data session) is being used.
Changelog
Bug Fixes
CLA