Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak IAP transport to only delay control sessions, not data sessions #1385

Merged
merged 4 commits into from
Oct 9, 2019

Conversation

joeljfischer
Copy link
Contributor

Fixes #1240

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

Smoke tests were performed with the following scenarios:

  1. 6 apps were forced to connect with this branch on the control protocol repeatedly.
  2. 13 apps were forced to connect with this branch on the multisession protocol repeatedly.

Summary

This PR updates the IAP transport to only delay apps from connecting with their retry delay when the control session is being used for connection, not when the multisession protocol (direct to data session) is being used.

Changelog

Bug Fixes
  • Connecting to newer head units using the multisession protocol is sped up.

CLA

@joeljfischer joeljfischer added the bug A defect in the library label Aug 14, 2019
@joeljfischer joeljfischer added this to the 6.4.0 milestone Aug 14, 2019
@joeljfischer joeljfischer self-assigned this Aug 14, 2019
@NicoleYarroch
Copy link
Contributor

There are some issues with changing the head unit language:

  1. If the SDL app is connected to the head unit when the user changes the head unit language, the ChangeRegistration fails most of the time due VR not being ready (I consider this to be an edge case).
  2. The session often fails to close correctly when switching the head unit language while the SDL app is connected. I tested closing the session if the I/O thread in the data session does not close in the sdl_accessoryEventLoop and it seemed to fix the issue: https://gist.github.com/NicoleYarroch/1861152ac88f07e59fba9ca5b4173f6c

Copy link
Contributor

@NicoleYarroch NicoleYarroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment about some issues.

SmartDeviceLink/SDLIAPTransport.m Outdated Show resolved Hide resolved
@joeljfischer
Copy link
Contributor Author

I added your suggested fix for (2). I'm not seeing an issue with (1) here.

@joeljfischer joeljfischer merged commit d2f5379 into develop Oct 9, 2019
@joeljfischer joeljfischer deleted the bugfix/issue_1240_data_session_delay branch October 9, 2019 13:21
@mrapitis mrapitis mentioned this pull request Oct 28, 2019
1 task
@joeljfischer joeljfischer restored the bugfix/issue_1240_data_session_delay branch October 28, 2019 14:54
@joeljfischer joeljfischer deleted the bugfix/issue_1240_data_session_delay branch February 7, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants