-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDL 0213 - Remote Control - Radio and Climate Parameter Update #643
Comments
Can As a meta point, it would be nice if proposals didn't package all the changes together into one proposal, but that climate, radio, etc. changes were separated into separate proposals. |
I agree with @joeljfischer we should not be submitting/reviewing proposals that update multiple items if they are not specifically related. For example, all remote control proposals should only include a single module type. This point was actually brought up in a previously submitted proposal for RC changes #296.
|
@joeljfischer I agree that we can deprecated parameter @joeygrover I think it is really a simple change to update the parameters in this proposal, even it has two remote control modules updated. I think the scope is very limited and it shall not have anything prevent the reviewers to understand the proposal. The point brought up before is saying limiting the scope of proposal will make it easier understanding and discussion, but it does not say it is a pre-condition of submitting/reviewing proposals. |
@joeljfischer @joeygrover we will consider separate proposals per rc module moving forward with new proposals but not for this proposal |
@yang1070 To be clear, I think |
@joeljfischer Yes, you are correct. Basically, for a parameter in module control data, there is a corresponding data in the capabilities. Both shall be deprecated. |
The Steering Committee voted to accept this proposal with revisions. The author is to update this proposal to state that |
Hello SDL community,
The review of "SDL 0213 - Remote Control - Radio and Climate Parameter Update" begins now and runs through December 18, 2018. The proposal is available here:
https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0213-rc-radio-climate-parameter-update.md
Reviews are an important part of the SDL evolution process. All reviews should be sent to the associated Github issue at:
#643
What goes into a review?
The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of SDL. When writing your review, here are some questions you might want to answer in your review:
Please state explicitly whether you believe that the proposal should be accepted into SDL.
More information about the SDL evolution process is available at
https://github.com/smartdevicelink/sdl_evolution/blob/master/process.md
Thank you,
Jordyn Mackool
Program Manager - Livio
[email protected]
The text was updated successfully, but these errors were encountered: