Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accepted with Revisions] SDL 0099 - New remote control modules (LIGHT, AUDIO, HMI_SETTINGS) and parameters (SIS Data) #296

Closed
theresalech opened this issue Sep 20, 2017 · 4 comments

Comments

@theresalech
Copy link
Contributor

Hello SDL community,

The review of "New remote control modules (LIGHT, AUDIO, HMI_SETTINGS) and parameters (SIS Data)" begins now and runs through September 26, 2017. The proposal is available here:

https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0099-new-remote-control-modules-and-parameters.md

Reviews are an important part of the SDL evolution process. All reviews should be sent to the associated Github issue at:

#296

What goes into a review?

The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of SDL. When writing your review, here are some questions you might want to answer in your review:

  • Is the problem being addressed significant enough to warrant a change to SDL?
  • Does this proposal fit well with the feel and direction of SDL?
  • If you have used competitors with a similar feature, how do you feel that this proposal compares to those?
  • How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
    Please state explicitly whether you believe that the proposal should be accepted into SDL.

More information about the SDL evolution process is available at

https://github.com/smartdevicelink/sdl_evolution/blob/master/process.md

Thank you,
Theresa Lech

Program Manager - Livio
[email protected]

@theresalech
Copy link
Contributor Author

The Steering Committee voted to accept this proposal with revisions. The author will revise the proposal to fix a few typos, as well as include descriptions for the groups of lights - listing which single light elements they typically include. It was also noted that limiting the scope of proposals, especially those related to Remote Control, in the future will help to make for easier understanding and discussion among SDLC Members.

@theresalech
Copy link
Contributor Author

@yang1070 please advise when a new PR has been entered to update the proposal to reflect the agreed upon revisions. I'll then merge the PR so the proposal is up to date, and enter an issue in the iOS repository for implementation. Thanks!

@theresalech theresalech changed the title [In Review] SDL 0099 - New remote control modules (LIGHT, AUDIO, HMI_SETTINGS) and parameters (SIS Data) [Accepted with Revisions] SDL 0099 - New remote control modules (LIGHT, AUDIO, HMI_SETTINGS) and parameters (SIS Data) Sep 27, 2017
@smartdevicelink smartdevicelink locked and limited conversation to collaborators Sep 27, 2017
@theresalech
Copy link
Contributor Author

Proposal has been revised to include descriptions and fix typos. Issues have been entered:
Core
iOS
Android
RPC

@theresalech
Copy link
Contributor Author

This proposal is revised by SDL 0182

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant