-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trigger ptu on startup only in proprietary policy mode #3415
Conversation
@iCollin The root cause of the defect was: |
@@ -790,7 +790,7 @@ void PolicyHandler::OnSystemRequestReceived() const { | |||
} | |||
|
|||
void PolicyHandler::TriggerPTUOnStartupIfRequired() { | |||
#ifndef EXTERNAL_PROPRIETARY_MODE | |||
#ifdef PROPRIETARY_MODE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iCollin The root cause of the defect was: SDL does not start PTU sequence in HTTP mode
and you changed that it would start it only in PROPRIETARY
. Is this correct?
@AByzhynar Yes, thank you for noticing. It is difficult to understand because #3279 was related to multiple different PRs - the first fix PR(#3280) is related to the KMS trigger. The second fix PR(#3294) is related to the Ignition and DaysAfter triggers. The third PR (#3363) fixes the same issue as the second PR(which seems to have been broken by other Policy fixes before the release). PR #3363 was meant to address the following issue: In regular policy mode, days and ignition cycles triggers are not checked when core starts up. |
@iCollin While this does limit the #3363 fix to only work for PROPRIETARY policy mode, the PTU trigger check for Ignition cycles and days after won't work if there are no apps registered. Which means the "HMI PTU trigger with no apps" test cases for ignition cycles and daysAfter would fail for HTTP_POLICY mode. Is that a restriction we want to make? |
It looks like HTTP policy mode does not rely on the HMI at all for the PTU process. In which case, the HMI PTU tests wouldn't apply for this policy mode. It should be fine then to restrict the #3363 fix to only work for PROPRIETARY policy mode |
Fixes #3396
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
ATF
Summary
only "triggerPTUonStartup" in proprietary mode
CLA