Fix/Checking PTU triggers when no apps are registered in regular policy mode #3294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
…e policy_manager as well
This reverts commit 7c53978.
Jack-Byrne
approved these changes
Mar 19, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3279
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
ATF tests 019 and 020 in smartdevicelink/sdl_atf_test_scripts#2368
Summary
Currently, the IgnitionCycles and Days PTU triggers are not checked in the regular policy mode when SDL starts. In the external policy manager, this check is triggered in
PolicyManagerImpl::SetUserConsentForDevicewhenStartPTExchangeis called.PolicyManagerImpl::SetUserConsentForDeviceseems to be missing this functionality in the regular policy manager.This PR adds a call for
StartPTExchangeinPolicyManagerImpl::SetUserConsentForDevicewhen the consent is allowed in the regular policy mode.CLA