Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCIP-4428 Decouple LiquidityManager tests with LockReleaseTokenPool #16017

Merged
merged 14 commits into from
Jan 24, 2025
Merged

CCIP-4428 Decouple LiquidityManager tests with LockReleaseTokenPool #16017

merged 14 commits into from
Jan 24, 2025

Conversation

0xsuryansh
Copy link
Member

@0xsuryansh 0xsuryansh commented Jan 21, 2025 •
edited
Loading

  1. Decouple LiquidityManager tests from LockReleaseTokenPool by creating a stub for lock release pool
  2. Split & rename tests according to foundry style guide

@0xsuryansh 0xsuryansh requested a review from a team as a code owner January 21, 2025 19:49
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025 •
edited
Loading

Solidity Review Jira issue

Hey! We have taken the liberty to link this PR to a Jira issue for Solidity Review.

This is a new feature, that's currently in the pilot phase, so please make sure that the linkage is correct. In a contrary case, please update it manually in JIRA and replace Solidity Review issue key in the changeset file with the correct one.
Please reach out to the Test Tooling team and notify them about any issues you encounter.

Any changes to the Solidity Review Jira issue should be reflected in the changeset file. If you need to update the issue key, please do so manually in the following changeset file: contracts/.changeset/five-brooms-knock.md

This PR has been linked to Solidity Review Jira issue: CCIP-3966

jhweintraub
jhweintraub reviewed Jan 22, 2025
View reviewed changes
contracts/src/v0.8/liquiditymanager/test/LiquidityManager.setCrossChainRebalancer.t.sol Outdated
import {LiquidityManager} from "../LiquidityManager.sol";

contract LiquidityManager_setCrossChainRebalancer is LiquidityManagerSetup {
event CrossChainRebalancerSet(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this event be imported from LiquidityManager directly instead of being redefined.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not resolved

jhweintraub
jhweintraub previously approved these changes Jan 22, 2025
View reviewed changes
RensR
RensR reviewed Jan 23, 2025
View reviewed changes
contracts/src/v0.8/liquiditymanager/test/LiquidityManager.receive.t.sol Outdated
import {LiquidityManagerSetup} from "./LiquidityManagerSetup.t.sol";

contract LiquidityManager_receive is LiquidityManagerSetup {
event NativeDeposited(uint256 amount, address depositor);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please always reference events instead of duplicating if possible

contracts/src/v0.8/liquiditymanager/test/LiquidityManager.receive.t.sol Outdated
contract LiquidityManager_receive is LiquidityManagerSetup {
event NativeDeposited(uint256 amount, address depositor);

address private depositor = makeAddr("depositor");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not needed as global with a single test?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, moved to local

contracts/src/v0.8/liquiditymanager/test/LiquidityManager.setCrossChainRebalancer.t.sol Outdated
import {LiquidityManager} from "../LiquidityManager.sol";

contract LiquidityManager_setCrossChainRebalancer is LiquidityManagerSetup {
event CrossChainRebalancerSet(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not resolved

contracts/src/v0.8/liquiditymanager/test/LiquidityManagerSetup.t.sol Outdated

import {IERC20} from "../../vendor/openzeppelin-solidity/v4.8.3/contracts/token/ERC20/IERC20.sol";

// FOUNDRY_PROFILE=liquiditymanager forge test --match-path src/v0.8/liquiditymanager/test/LiquidityManager.t.sol
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to remove

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@jhweintraub jhweintraub added this pull request to the merge queue Jan 24, 2025
Merged via the queue into develop with commit 17a9e2a Jan 24, 2025
121 of 122 checks passed
@jhweintraub jhweintraub deleted the CCIP-4428_decouple-liquiditymanagetests-ccip-pool branch January 24, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhweintraub jhweintraub jhweintraub approved these changes

@RensR RensR RensR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xsuryansh @RensR @jhweintraub